feat: Implemented Event Start & End Time with Optimized UI Tags#215
feat: Implemented Event Start & End Time with Optimized UI Tags#215VarshiniSuresh90 wants to merge 7 commits intoFOSSUChennai:mainfrom
Conversation
|
Hey @VarshiniSuresh90 thanks a lot for your contribution, but the UI has changed a bit drastic compared to the UI in production 
please do look into the card UI and then the warning tag makes the text bold which is ideally not what we want and not consistent with our other tags. 
also there are few other suggestions aswell in the UI design, I have not yet reviewed the code yet but will do that once all the UI part is finalised @VarshiniSuresh90 Thanks a lot for the contribution tho, Cheers :) |
| }, | ||
| "dependencies": { | ||
| "@phosphor-icons/react": "^2.1.7", | ||
| "@radix-ui/react-tooltip": "^1.1.8", |
There was a problem hiding this comment.
curious to know the use case, we would love to not add more dependencies to the project @VarshiniSuresh90
There was a problem hiding this comment.
incase you want to use a tooltip, we have a component for tooltip that we have built. You can use that
| import { useState } from 'react'; | ||
| import events from '../../../data/events.json'; | ||
| import { MapPin } from '@phosphor-icons/react'; | ||
| import { MapPin } from 'phosphor-react'; |
There was a problem hiding this comment.
please update back to the newer version of @phophor-icons/react that we have added in as a dependency @VarshiniSuresh90
| communityName: string; | ||
| title: string; | ||
| date: string; | ||
| startTime: string; |
There was a problem hiding this comment.
just the eventTime from the events.json should be more than enough @VarshiniSuresh90
lets keep the details as what we have already requested from users.
| <section> | ||
| <h2 className='mb-3 text-lg font-normal'> | ||
| <span className='text-[30px] font-semibold text-black'>this month</span> | ||
| <span className='text-[30px] font-semibold text-black'>This Month</span> |
There was a problem hiding this comment.
please change back to this month and upcoming, it is part of the design system of tt.
| "eventTime": "08:30", | ||
| "eventVenue": "Sathyabama University", | ||
| "eventLink": "https://community.cncf.io/kcd-chennai/", | ||
| "eventStartTime": "08:30", |
There was a problem hiding this comment.
just like I mentioned above, lets not complicate things with more information, we can display just the start time and that should be good
|
Sure ! @JustinBenito I will make the necessary changes and revert you back soon. Thanks for your feedback. |
|
Thanks a lot @VarshiniSuresh90 |
|
@VarshiniSuresh90 can you please look into this and update it :) |
|
@VarshiniSuresh90, any update on this PR? |
Sarveshmrao
added
enhancement
3 participants
Thank you for your valuable feedback @JustinBenito ! I have implemented the requested changes and ensured the UI remains consistent. And kindly check if the code has reflected the changes.
Below are the key updates in this PR:
I believe these updates fully align with the existing design while incorporating the requested improvements. Please review the PR, and if everything looks good, I would be grateful if you could procees and consider merging it.
New UI
existing UI