Skip to content

Comments

feat(dark-mode): add dark mode toggle functionality#228

Open
Mohammed-Thaha wants to merge 4 commits intoFOSSUChennai:mainfrom
Mohammed-Thaha:dark-mode-ui
Open

feat(dark-mode): add dark mode toggle functionality#228
Mohammed-Thaha wants to merge 4 commits intoFOSSUChennai:mainfrom
Mohammed-Thaha:dark-mode-ui

Conversation

@Mohammed-Thaha
Copy link
Contributor

This pull request introduces a Dark Mode feature using a class-based strategy in Next.js, enhancing the user experience, especially in low-light environments. The implementation includes:

A toggle switch to enable/disable Dark Mode.

Persistent theme state management using localStorage.

Class-based theme switching (dark class applied to ).

Optimized styles to maintain readability and accessibility across all UI elements.

Additional Notes:

Open to any suggestions for improvement.

Let me know if any changes are required.

@JustinBenito and @nammahari for review. Looking forward to your feedback! 🚀

I have attach the screenshot below

Light Mode

Screenshot 2025-04-02 200855
Screenshot 2025-04-02 200914
Screenshot 2025-04-02 200924

Dark Mode

Screenshot 2025-04-02 200936
Screenshot 2025-04-02 201001
Screenshot 2025-04-02 201010

Thank You for reviewing my PR

@Mohammed-Thaha
Copy link
Contributor Author

Make the dark mode toggle button responsive on small screens and attach a screenshot of its responsiveness. Let me know if there are any issues.

Screenshot 2025-04-02 215417

Screenshot 2025-04-02 215425

@nammahari
Copy link
Collaborator

Hey, Thanks For your contribution. To be honest, I don't think we need a dark mode feature for this site specifically so I am passing this and the PR is still open for community thoughts.

@Mohammed-Thaha
Copy link
Contributor Author

Got it, thanks for sharing your thoughts! I appreciate you keeping the PR open for community input—happy to revisit if needed

@selvasudar
Copy link
Contributor

@nammahari Usually most of the developers love to code in Dark Mode. This Dark Mode feature definitely adds indirect value to the website that it is for frontend developers too. Just my thought.

@nammahari
Copy link
Collaborator

@nammahari Usually most of the developers love to code in Dark Mode. This Dark Mode feature definitely adds indirect value to the website that it is for frontend developers too. Just my thought.

I do agree with that point most developers do prefer coding in Dark Mode. However, for a directory-style website, I’d recommend sticking with a light theme.

Dark themes tend to work better for utility or functional apps. Given the color scheme we're using for this site, I don't think a dark theme is necessary or adds much value in this context.

@Sarveshmrao Sarveshmrao added stale discussion community discussion labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion community discussion stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants