Open
Conversation
Collaborator
|
Thanks for adding this! We're very busy getting ready for competition, but I'll look at this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This project is really impressive, but one thing that could make it better is being able to POST the results somewhere. I added a field for the URL of the API to push to, along with an optional
authtoken that can be sent. There's a button on the modal that can be used to send the data.The data is sent as JSON, with two fields:
data, which is the text data from the form, andauth, which can be specified. The frontend doesn't do anything with it, it's purely for the backend to use.In addition, a few form fields didn't have defaults, which was leading to
undefinedvalues being sent. That's been addressed in9f45849and 1f0b11a`.