Skip to content

Conversation

@iloftis-fsq
Copy link
Contributor

Changed split max on variables to 2 in drake/core.clj, to preserve equals signs in variable values

@iloftis-fsq iloftis-fsq requested a review from irisxingfu April 11, 2022 21:13
Comment on lines +35 to +37
[org.apache.hadoop/hadoop-mapreduce-client-core "2.6.0-cdh5.13.0"]
[org.apache.hadoop/hadoop-hdfs "2.6.0-cdh5.13.0"]
[org.apache.hadoop/hadoop-common "2.6.0-cdh5.13.0"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these necessary?

Comment on lines +3 to +14
:repositories {"cloudera" "https://repository.cloudera.com/content/groups/cdh-releases-rcs"
"foursquare" {:url "https://foursquaredev.jfrog.io/foursquaredev/fsnexus"
:username :env/MVN_USERNAME :password :env/MVN_PASSWORD}
}
:deploy-repositories {"snapshots" {:id "foursquare"
:url "https://foursquaredev.jfrog.io/foursquaredev/fsfactual-snapshots-local"
:username :env/MVN_USERNAME :password :env/MVN_PASSWORD
:sign-releases false}
"releases" {:id "foursquare"
:url "https://foursquaredev.jfrog.io/foursquaredev/fsfactual-releases-local"
:username :env/MVN_USERNAME :password :env/MVN_PASSWORD
:sign-releases false}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand these changes, where did they come from and why are those so different?

@irisxingfu irisxingfu removed their request for review May 18, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants