Jan24 patches #575

fuhlig1 · 2025-09-16T09:34:04Z

Fix the build systems of several packages to allow the usage of CMake 4.0.
Fix compilation issues with Apple Clang 17
Allow to use a non standard (older) SDK to allow compilation with Clang 17
- Don't overwrite CMAKE_OSX_SYSROOT which is passed as CMake parameter
- Pass CMAKE_OSX_SYSROOT to all package build systems
- Fix ROOT build system such that rootcint takes into account the defined CMAKE_OSX_SYSROOT

legacy/root/fix_macos_sdk_for_rootcling.patch

legacy/README.md

legacy/geant3/fix_cmake.patch

cmake/legacy.cmake

Also fix an issue with the usage of the pythia6 library. The libarary wasn't found any longer such that it is explicitly added as dependency.

The fix prevents a crash about wrong CMake versions when compiling geant4_vmc.

Before a SDK defined via the CMake parameter CMAKE_OSX_SYSROOT was overwritten with the value extracted from brew.

Clang 17 remove the header fp.h which is used in ROOT's copy of libAfterimage. Add a patch which uses math.h instead. The included ROOT version can't be compiled any longer with the SDK 15. Specifing the older SDK 14 when running CMake (with -DCMAKE_OSX_SYSROOT) only works partly since rootcling still uses the latest SDK version. Add a patch such that rootcling also uses the specified SDK. All projects depending on ROOT need also to set CMAKE_OSX_SYSROOT to the same value used when building ROOT. Otherwise the dictionary generation may fail. Fix patch for ROOT using CMAKE_OSX_SYSROOT minimize the patch

Fix a typo in the code. This code could actually never be compiled and it is unclear why this compilation error only popped up now with Clang 17.

The default bash version on macosx is to old to support all features needed in the test suite of FairRoot. The system version of make doesn't properly support the jobserver such that the build process ins't properly parallelized.

Describe some known problems on macosx and the corresponding solutions.

Pass the needed information to the boost build system if a non standard SDK is used.

Pass the needed information to the pythia8 build system if a non standard SDK is used.

fuhlig1 · 2025-09-24T06:34:56Z

@dennisklein,

I have added two more commits which now also build pythia8 and boost with the proper settings. I had overlokked both packages before.

If your are fine with the PR I would like to squash some of the new commits and merge the PR.

dennisklein · 2025-09-24T07:23:14Z

If your are fine with the PR I would like to squash some of the new commits and merge the PR.

👍

Some legacy C code can't be compiled with C standard version 23 which is the new default for gcc15 so use C standard version 11 for the compilation. Add some missing include statements for <stdint>. Probably due to header cleanup in the include files of gcc 15.

The legacy C code can't be compiled with C standard version 23 which is the new default for gcc15 so use C standard version 11 for the compilation. For unknown reasons the pythia library isn't found any longer which is fixed by adding possible library names.

Use C11 as standard C version when compiling FairRoot. The C code of the MbsApi can't be compiled with C23 which is the new default version with gcc15.

Copilot

Pull Request Overview

This PR addresses compilation and build system compatibility issues for CMake 4.0 and Apple Clang 17, with specific focus on macOS SDK handling. The changes enable FairSoft to work with newer toolchain versions while maintaining backward compatibility.

Key changes include:

Updated CMake version requirements across multiple packages to support CMake 4.0
Fixed compilation issues with Apple Clang 17 through patches and SDK handling
Enhanced macOS build system to use proper tools (bash, make, patch) and SDK configuration

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/legacy/fairroot.sh.in	Added C standard specification for FairRoot build
legacy/*/fix_cmake.patch	Updated cmake_minimum_required statements to support CMake 4.0.1
legacy/setup-macos.sh	Added bash and make packages to macOS dependencies
legacy/root/*.patch	Applied fixes for Apple Clang 17 compatibility and SDK handling
legacy/geant4/*.patch	Fixed typos and CMake compatibility issues
legacy/advanced.md	Updated documentation about SDK usage with newer compilers
legacy/README.md	Added detailed macOS compilation instructions
cmake/legacy.cmake	Enhanced macOS tool detection and SDK propagation
FairSoftConfig.cmake	Modified to respect externally set CMAKE_OSX_SYSROOT

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-01T14:33:31Z

legacy/advanced.md

+The downside with picking the latest SDK version is that some older ROOT
+versions can't be compiled any longer after updating the compiler and the
+connected SDK. As described above the problems with compilation errors due
+to **wrong** SDKs are because of ROOT and there mainly becuase of rootcling.


Spelling error: 'becuase' should be 'because'.

Suggested change

to **wrong** SDKs are because of ROOT and there mainly becuase of rootcling.

to **wrong** SDKs are because of ROOT and there mainly because of rootcling.

Copilot · 2025-10-01T14:33:31Z

legacy/README.md

+commands on macosx.
+
+The **patch** command does not support the needed parameters,
+so one needs ot install a version of the **patch** command with brew.


Spelling error: 'ot' should be 'to'.

Suggested change

so one needs ot install a version of the **patch** command with brew.

so one needs to install a version of the **patch** command with brew.

Copilot · 2025-10-01T14:33:32Z

legacy/root/fix_macos_sdk_for_rootcling.patch

+    if not existing_ldlib: existing_ldlib = ""
+    my_env["LD_LIBRARY_PATH"] = os.path.join(rootdir, "lib") + ":" + existing_ldlib
+   if osx_sdk:
+      my_env["SDKROOT"] = 'osx_sdk'


String literal 'osx_sdk' should be the variable osx_sdk without quotes to use the actual SDK path value.

Suggested change

+ my_env["SDKROOT"] = 'osx_sdk'

+ my_env["SDKROOT"] = osx_sdk

dennisklein · 2025-10-01T15:54:50Z

@copilot Summarize all changes by commit and check whether the commit describes the changes adequately. If needed, suggest improvements.

dennisklein · 2025-10-02T08:15:59Z

Commit Summary for PR #575

I've analyzed all 21 commits in this PR. Here's a comprehensive summary organized by topic:

1. CMake 4.0 Compatibility Fixes (7 commits)

These commits fix build systems to support CMake 4.0.1 by updating cmake_minimum_required() declarations:

dbabc9e [legacy] hepmc: Fix build system for CMake 4.0.1
abcdaa8 [legacy] zeromq: Fix build system for CMake 4.0.1
3e5a333 [legacy] vc: Fix build system for CMake 4.0.1
50a2207 [legacy] pythia6: Fix build system for CMake 4.0.1
b3ae9d8 [legacy] vmc: Fix build system for CMake 4.0.1
4abb7d2 [legacy] vgm: Fix build system for CMake 4.0.1
3d87072 [legacy] geant4_vmc: Fix build system for CMake 4.0.1

Assessment: ✅ Commit messages are clear and consistent. The pattern is good.

2. Geant Fixes (2 commits)

03ff645 [legacy] geant3: Fix build system for CMake 4.0.1
- Changes: Adds CMake 4.0 support + fixes pythia6 library dependency issue
- Suggestion: Could be split into two commits (CMake version + pythia6 fix) OR rename to "[legacy] geant3: Fix build system for CMake 4.0.1 and pythia6 dependency"
baea65d [legacy] geant4: Fix config file
- Changes: Prevents CMake version crash in geant4_vmc
- Assessment: ✅ Good. Body explains the specific issue well.

3. macOS SDK and Clang 17 Support (7 commits)

de22628 [legacy] build system: Allow setting the proper SDK
- Assessment: ✅ Clear. Prevents overwriting CMAKE_OSX_SYSROOT.
6ea4176 [legacy] root: Fix compilation on macosx with Clang 17 and SDK 15
- Assessment: ✅ Excellent. Comprehensive body explains multiple issues: fp.h removal, SDK version handling, rootcling SDK fix.
e1ac728 [legacy] geant4: Fix compilation crash with Clang 17
- Assessment: ✅ Good. Explains it's a typo fix.
6a82620 [legacy] setup scripts: Add new packages for macosx
- Assessment: ✅ Good. Explains bash and make issues on macOS.
cd3a4e0 [legacy] On macosx use Homebrews patch and make
- Assessment: ⚠️ Missing body. Should explain why (references gpatch/gmake availability and jobserver support).
a212554 [legacy] documentation: Add infos macosx
- Suggestion: Typo in title: "infos" → "info for" or "information for"
- Assessment: ✅ Body is clear.
a288850 [legacy] boost: Build Boost with correct SDK
- Assessment: ✅ Clear and concise.
ee8846e [legacy] pythia8: Build Pythia8 with correct SDK
- Assessment: ✅ Clear and concise.

4. GCC 15 Compatibility (3 commits)

49a454d [legacy] root: Fix build with gcc15
- Assessment: ✅ Excellent. Explains C23 standard issue and missing headers.
6678e08 [legacy] geant3: Fix compilation for gcc15
- Assessment: ✅ Good. Explains C23 issue and pythia library finding problem.
24febab [legacy] tests: Fix test for gcc15
- Assessment: ✅ Clear. Explains MbsApi C23 incompatibility.

5. Debian 13 Compatibility (1 commit)

8fac280 [legacy] root: Fix compilation for Debian13
- Assessment: ✅ Excellent. Provides context, references upstream fix, and links to Debian bug report.

Overall Assessment

Strong Points:

Most commits have clear, descriptive messages
Complex changes (ROOT/Clang17, Debian13) have excellent explanations
Good use of commit bodies to provide context

Suggestions for Improvement:

cd3a4e0 - Add commit body explaining the rationale for using Homebrew's patch and make
a212554 - Fix typo: "Add infos macosx" → "Add info for macOS" or "Add macOS information"
03ff645 - Consider renaming or splitting since it addresses both CMake 4.0 AND pythia6 dependency

Minor Issues Found:

Spelling errors in documentation (already flagged by copilot bot):
- legacy/advanced.md line 65: "becuase" → "because"
- legacy/README.md line 62: "ot install" → "to install"
- legacy/root/fix_macos_sdk_for_rootcling.patch: 'osx_sdk' should be osx_sdk (without quotes)

Overall, the commits are well-structured and the PR is ready for merge after addressing the minor suggestions above! 🎉

dennisklein · 2025-10-02T08:18:46Z

@fuhlig1 copilot does not yet respond to questions posted here directly, so I installed github copilot CLI and told it to reply to it, which it did as my user.

The version of ftgl contained in the ROOT source code results in a compilation error with the gcc14 compiler suite used in Debian 13 and the gcc15 compiler suite in OpenSuse 16.0. For all other tested system the code is okay. The problem was also found by the Debian team https://www.mail-archive.com/debian-qa-packages@lists.debian.org/msg81745.html and a fix is available from upstream frankheckenbach/ftgl#20 Add a cmake check for OS and apply the fix only in case a Debian 13 or OpenSuse 16.0 is found.

Properly pass CMAKE_OSX_SYSROOT to the build and test processes. Don't test building onnxruntime if CMake version >= 4.0.0

rlalik · 2025-12-08T21:45:10Z

Hi, before I discovered the patches branches I also fixed the cmake issue for myself. Perhaps the solution proposed by cmake which does not require patching cmake files but passing proper options, would be better to use here? See here: b56c23d

fuhlig1 added 7 commits June 18, 2025 13:37

[legacy] hepmc: Fix build system for CMake 4.0.1

dbabc9e

[legacy] zeromq: Fix build system for CMake 4.0.1

abcdaa8

[legacy] vc: Fix build system for CMake 4.0.1

3e5a333

[legacy] pythia6: Fix build system for CMake 4.0.1

50a2207

[legacy] vmc: Fix build system for CMake 4.0.1

b3ae9d8

[legacy] vgm: Fix build system for CMake 4.0.1

4abb7d2

[legacy] geant4_vmc: Fix build system for CMake 4.0.1

3d87072

fuhlig1 requested review from dennisklein and karabowi September 16, 2025 09:34

fuhlig1 added the bug label Sep 16, 2025

fuhlig1 force-pushed the jan24_patches branch from 141551b to 14a53f3 Compare September 17, 2025 11:45

dennisklein reviewed Sep 22, 2025

View reviewed changes

legacy/root/fix_macos_sdk_for_rootcling.patch Outdated Show resolved Hide resolved

dennisklein reviewed Sep 22, 2025

View reviewed changes

legacy/README.md Outdated Show resolved Hide resolved

dennisklein reviewed Sep 22, 2025

View reviewed changes

legacy/geant3/fix_cmake.patch Show resolved Hide resolved

fuhlig1 force-pushed the jan24_patches branch from 14a53f3 to 9f1b240 Compare September 22, 2025 12:40

dennisklein reviewed Sep 22, 2025

View reviewed changes

cmake/legacy.cmake Show resolved Hide resolved

fuhlig1 added 8 commits September 22, 2025 17:16

[legacy] geant3: Fix build system for CMake 4.0.1

03ff645

Also fix an issue with the usage of the pythia6 library. The libarary wasn't found any longer such that it is explicitly added as dependency.

[legacy] geant4: Fix config file

baea65d

The fix prevents a crash about wrong CMake versions when compiling geant4_vmc.

[legacy] build system: Allow setting the proper SDK

de22628

Before a SDK defined via the CMake parameter CMAKE_OSX_SYSROOT was overwritten with the value extracted from brew.

[legacy] geant4: Fix compilation crash with Clang 17

e1ac728

Fix a typo in the code. This code could actually never be compiled and it is unclear why this compilation error only popped up now with Clang 17.

[legacy] setup scripts: Add new packages for macosx

6a82620

The default bash version on macosx is to old to support all features needed in the test suite of FairRoot. The system version of make doesn't properly support the jobserver such that the build process ins't properly parallelized.

[legacy] On macosx use Homebrews patch and make

cd3a4e0

[legacy] documentation: Add infos macosx

a212554

Describe some known problems on macosx and the corresponding solutions.

fuhlig1 force-pushed the jan24_patches branch from 9f1b240 to a212554 Compare September 22, 2025 15:33

fuhlig1 added 2 commits September 23, 2025 14:59

[legacy] boost: Build Boost with correct SDK

a288850

Pass the needed information to the boost build system if a non standard SDK is used.

[legacy] pythia8: Build Pythia8 with correct SDK

ee8846e

Pass the needed information to the pythia8 build system if a non standard SDK is used.

fuhlig1 added 2 commits September 29, 2025 08:24

[legacy] tests: Fix test for gcc15

24febab

Use C11 as standard C version when compiling FairRoot. The C code of the MbsApi can't be compiled with C23 which is the new default version with gcc15.

fuhlig1 force-pushed the jan24_patches branch from 066b1c3 to 24febab Compare September 29, 2025 06:25

dennisklein requested a review from Copilot October 1, 2025 14:32

Copilot AI reviewed Oct 1, 2025

View reviewed changes

fuhlig1 force-pushed the jan24_patches branch from 4924b1f to 5a73be2 Compare October 11, 2025 16:09

fuhlig1 added 3 commits October 11, 2025 19:03

[legacy] test: Allow test with non standard SDK on macosx

c3c9f3f

Properly pass CMAKE_OSX_SYSROOT to the build and test processes. Don't test building onnxruntime if CMake version >= 4.0.0

[legacy] test: Add test of FairRoot dev branch

63cbc99

fuhlig1 force-pushed the jan24_patches branch from 5a73be2 to 63cbc99 Compare October 11, 2025 17:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jan24 patches #575

Jan24 patches #575

fuhlig1 commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fuhlig1 commented Sep 24, 2025

Uh oh!

dennisklein commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

Copilot AI Oct 1, 2025

Uh oh!

dennisklein commented Oct 1, 2025 •

edited

Loading

Uh oh!

dennisklein commented Oct 2, 2025

Uh oh!

dennisklein commented Oct 2, 2025

Uh oh!

rlalik commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	to wrong SDKs are because of ROOT and there mainly becuase of rootcling.
	to wrong SDKs are because of ROOT and there mainly because of rootcling.

	so one needs ot install a version of the patch command with brew.
	so one needs to install a version of the patch command with brew.

	+ my_env["SDKROOT"] = 'osx_sdk'
	+ my_env["SDKROOT"] = osx_sdk

Jan24 patches #575

Are you sure you want to change the base?

Jan24 patches #575

Conversation

fuhlig1 commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fuhlig1 commented Sep 24, 2025

Uh oh!

dennisklein commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

dennisklein commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dennisklein commented Oct 2, 2025

Commit Summary for PR #575

1. CMake 4.0 Compatibility Fixes (7 commits)

2. Geant Fixes (2 commits)

3. macOS SDK and Clang 17 Support (7 commits)

4. GCC 15 Compatibility (3 commits)

5. Debian 13 Compatibility (1 commit)

Overall Assessment

Uh oh!

dennisklein commented Oct 2, 2025

Uh oh!

rlalik commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dennisklein commented Oct 1, 2025 •

edited

Loading