-
Notifications
You must be signed in to change notification settings - Fork 139
Let me pull #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fernando-Agosto
wants to merge
13
commits into
Fall2016-CIIC4010:master
Choose a base branch
from
Gardy291:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Let me pull #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mine is clicked reveal all mines
ivansdj68
added a commit
to ivansdj68/CIIC4010-Lab5
that referenced
this pull request
Mar 25, 2017
Anyways, it's now fixed. I made some comments in the meanwhile on things I worked on: /* Why is it only painting RED in the main diagonal row when I right click the colored tile??? * is it because of left over code from Lab 5???? It can't be, because I erased most of it.. * it may be the ifs/elses... * * Changed them to else ifs, didnt have any effect... * * When putting gridX2/Y2, it paints red ONLY when the tile has been initially colored; this could * indicate a priority with case 1 over case 3... * * En parte será el mismo problema del Lab 5? El ejercicio Fall2016-CIIC4010#1? * * Ok... cuando pongo el do-switch-while del case 1 aqui, me deja pintar de rojo un cuadro ya * pintado con el left-click y luego se friza el app... Nope, not the solution... * * La cosa es que solamente se puede pintar justo cuando le hagas left-click... * * Vamos a bregar con el row de abajo primero... (Fall2016-CIIC4010#1 left to MyPanel class) * */ /* (Fall2016-CIIC4010#1 Got here from MyMouseAdapter class after not achiving anything there related to the red right-click) * Ok, implementando el compnente c2, que es el que le pertence al case 3, pues por lo menos puedo * cambiar el color rojo a uno del left-click, lo cual antes no podia * Todavia me tiene pensando el comentario de "can loop among components"... * * Can color row 9! Still having issues with right-click though... * Had a shower of exceptions when clicking near the border of the most bottom row and right column; * fixed with * Back to MyMouse! (Fall2016-CIIC4010#2) */ He comentado algunas cosas del codigo viejo del Lab 5 por si acaso necesito esa referencia, aunque pronto se irán esos codigos...
-Fixed JFrame Name -Added square clearing recursion method on myPanel -Called method when left click on a square with no neighbores
-Erased unnecessary commentary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give me acces