[SM64] Geo Layout Export Node Optimization #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2023 20:50
…ing to place fMesh in parent node if skinned mesh is the first child
…ode, now all transform nodes simply begin at the geo layout root as god intended
Yanis002
reviewed
Dec 28, 2024
Collaborator
Yanis002
left a comment
Yanis002
left a comment
There was a problem hiding this comment.
I'm not an expert of this game but I can still review code so here we are, most comments are just function type hints and use is None/is not None when needed
Lilaa3
requested changes
Apr 17, 2025
Co-authored-by: Lila <lilaa3public@gmail.com>
|
This branch is omitting important commands to connect armatures using vertex stripping, breaking most animated actors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start nodes are removed unless explicitly placed by the user, now all geo nodes simply start with the root node of the object/bone placed by the user.
I also optimized skinning to combine the skinned mesh into the previous geo layout node if there was no nodes in between the previous animated bone and the child, instead of placing that skinned mesh in its own display list node.
I tested this on mario and a few other object geo layouts and exports did not show any visible errors. Mario experienced about a 20% reduce in line count.