[SM64] Fix skip act selector #644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
Skip Act Selectorfeature places the returns inside oflvl_set_current_leveltoo soon. This causes a few things to not properly update when transitioning levels, most notably the coin counter. I have changed it to put the returns at the bottom of the function instead.Also, if
Skip Act Selectorwas not selected, then any code matchingif (gCurrLevelNum == LEVEL_ENUM) return 0;in the entirelevel_update.cfile would get deleted. This probably would never be an issue in practice, but I have updated it to only look for that pattern inside of thelvl_set_current_levelfunction anyways.