Skip to content

Comments

chore(index): replace any type with union of poppler func typedefs#748

Merged
Fdawgs merged 2 commits intomainfrom
chore/index-parseoptions-type
Feb 18, 2026
Merged

chore(index): replace any type with union of poppler func typedefs#748
Fdawgs merged 2 commits intomainfrom
chore/index-parseoptions-type

Conversation

@Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Feb 18, 2026

Improves type safety and enables better IntelliSense/autocomplete in VS Code et al.

Checklist

Copilot AI review requested due to automatic review settings February 18, 2026 14:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves type safety in the parseOptions function by replacing the generic Record<string, any> type with a union of all specific Poppler function option types. This change enables better IntelliSense/autocomplete support in IDEs like VS Code by providing explicit type information for the options parameter.

Changes:

  • Replaced Record<string, any> with union of 12 specific option typedefs for the options parameter in parseOptions function JSDoc

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Fdawgs Fdawgs merged commit 1bff90d into main Feb 18, 2026
17 checks passed
@Fdawgs Fdawgs deleted the chore/index-parseoptions-type branch February 18, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant