-
Notifications
You must be signed in to change notification settings - Fork 31
Migrating TaskRunner based FeTS Task_1 Challenge to Workflow API #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! @Linardos: would it be possible for you to run through this branch with your existing FeTS Challenge setup to check if it works as expected? On a related note, we should put together a few unit tests for this. |
ec06ddb to
74cc059
Compare
a66ddb0 to
472c5a8
Compare
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Added workspace directory changes
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
472c5a8 to
a589591
Compare
Signed-off-by: Tarunkumar, Banda <tarunkumar.banda@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
Signed-off-by: Agrawal, Kush <kush.agrawal@intel.com>
a589591 to
f29bd32
Compare
|
Thanks for this @kagrawa2 ! Regarding
Do you happen to have any insights into what is specifically causing this issue? For simulation purposes, it is likely fine, but this seems like it could be a big issue in the long run if participants can potentially access another participant's dataloader. I've also seen deep copy issues come up in the past (unrelated to GaNDLF), so it may be worth tracking and addressing at some point in a more generic sense, too |
kminhta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After an offline sync, this looks good on my end on a technical side (migrating task runner to workflow api). Regarding the opens, 1-2 are under investigation and 3 is an expected issue that's easily resolvable as required.
I think it'll be contingent on compatibility with @Linardos 's challenge setup. Also, agree that it would be good to set up some tests - let us know if there are any specific one you want us to help create (cc @sarthakpati)
|
Thanks, I will sync offline with @Linardos to expedite the test + merge. |
@sarthakpati I will look into it and rebase. |
As part of this PR, we are migrating Task_1 challenge to be based on Workflow API Interface. For more details on Workflow API , refer this : https://openfl.readthedocs.io/en/latest/about/features_index/workflowinterface.html
We are running experiment with LocalRuntIme (https://openfl.readthedocs.io/en/latest/about/features_index/workflowinterface.html#localruntime)
Python(3.10 - 3.13) is now the supported version and OpenFL is also upgraded to 1.7.1.
Accordingly we have upgraded GaNDLF to version 0.1.0
Open Issues :
Testing :
Tested the changes locally by running the experiment with single process on CPU.
Testing the changes locally by running the experiment with single process on GPU.
Significant speedup observed with Ray backend on 4 GPUs.
Execution time reduced by ~75% compared to TaskRunner.