feat(multi-step-form-wrapper): added completion step #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
ps, apologies for the linting, didn't realize it changed the spacing. |
Owner
|
Thanks for the PR! I understand your proposal — you’re suggesting adding a completionStep prop so the Multi-Step Form can show a dedicated final screen after all steps are completed. I like the idea and it fits well with the component. |
Owner
|
I’m working on this component to make it easier for developers to implement and use. I’ll merge your PR once I’ve finalized the changes. |
Author
|
Awesome! Let me know if you need any help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice to add something like this, a completionStep on the multi-step-wrapper-form.
Upon completion of a multi-step-form, the user might be greeted with a completion state defined as a parameter of type React.ReactElement called completionStep in the MultiStepFormWrapperProps. The example has been updated to show this.
Feel free to suggest changes on this logic. If approved, I can write the added docs for features on this. Cheers.