fix: add tooltip, misc bug fixes, a11y fixes#59
Open
Conversation
…panda into feat/tooltip
justanothersynth
requested changes
Mar 9, 2023
nicole-code
approved these changes
Mar 9, 2023
Contributor
There was a problem hiding this comment.
Changes made that address this tickett all look great to me locally!
Thanks @joannaong & @timelytree !
justanothersynth
requested changes
Mar 9, 2023
nicole-code
suggested changes
Mar 16, 2023
Contributor
nicole-code
left a comment
There was a problem hiding this comment.
These may be a bit nit picky @timelytree and @joannaong but here goes ->
- This is happen when I tab over the page that I'm on - looks like the focus ring is cut off. Not sure if this is too nit picky
- If I'm tabbing through through the site for the first time, I always have to hit the
enterkey twice on theFiltersbutton before the filter panel opens - If the Filters panel is open and I don't close it, once I tab off of the panel, the panel still stays open which obstructs the view of the datasets list. I know this is working as expected but I think, if we have time, we could add something where if the user tabs off of the panel, the panel closes.
Let me know what you all think! I can create tickets for any of these if we want to address then :)
Contributor
Author
|
nicole-code
approved these changes
Mar 17, 2023
Contributor
nicole-code
left a comment
There was a problem hiding this comment.
Looks good on my end ! @joannaong @timelytree !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Screenshots
Ticket link