Upgrade V2 to angular 13 #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this going to be merged soon? This is one of the last dependencies we have still using ngcc |
ashleygmulligan2
approved these changes
Mar 16, 2023
ashleygmulligan2
left a comment
ashleygmulligan2
left a comment
There was a problem hiding this comment.
Tested, looks good. Thanks for your contribution!
|
@ltetreault-va or @jp-fiix - i have having issues getting master merged into your branch. Particularly one file isn't found on master. Do you mind rebasing this on master so that we can get it merged in? |
Author
|
@ashleygmulligan2 sorry for my late reply! I changed the base branch of my PR to FlatFilers:feat/legacy-v2 because we don't want my changes to be merged to the master which is portal v3. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the portal V2 connector to angular 13.