Load CGImage to ARGB to match vImage functions expected format #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yay - thanks for this. I'm going to hold off a merge until I get back home next weekend where I can look at it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vImage functions used expect a format of ARGB. CGImages where loaded as RGBA into
vImage_Buffers.Most functions would already worked as expected, since the vImage functions used does the same work on each channel respectively.
Though, if the flag
kvImageLeaveAlphaUnchangedwas used for the vImage functions, the red/R channel was left unchanged instead of the expected alpha/A channel. This happened since the alpha/A channel is the first in the expected buffer ARGB, but the format for th buffer supplied was RGBA.