Skip to content

Compile on Xcode Version 8.2.1 (8C1002), swift-3 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Norod wants to merge 3 commits into
base: swift-3
Choose a base branch
from
Open

Compile on Xcode Version 8.2.1 (8C1002), swift-3 #26

Norod wants to merge 3 commits into from

Conversation

@Norod
Copy link

@Norod Norod commented Feb 22, 2017 •
edited
Loading

Compile on Xcode Version 8.2.1 (8C1002), swift-3

  • Updated input arguments of vImageHistogramCalculation_ARGB8888 for Swift3
  • Adjusted input arguments of vImageHistogramSpecification_ARGB8888 for Swift3
  • Clicked a lot of "Fix it" hiding behind little red circles with a white dot in them 😒
  • Performed short sanity to make sure calls to vImageHistogramXXX are okay
  • Made sure it also compiles with non-simulator targets
  • Made sure it also runs the custom-Metal shaders

Known issue: Custom Metal filter only show the output if they are selected before any other filter

@Norod Norod closed this Feb 22, 2017
@Norod
Norod: Compile on non-simulator targets
899d8c4 
Norod: Known issue, Custom Metal filter only show the output if they are selected before any other filter
@Norod Norod reopened this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Norod