disabling tenant scope upon a flag #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mahathi, can you explain the change. If I understand it right, you want to ignore adding the tenant id to the sql queries. If that's the case, you can just ignore wrapping your code with acts_as_tenant. |
Author
|
I still need seller filter ganesh. |
|
ok. not very sure of the requirements. But please be aware that this is a public repo and used outside of flipkart as well |
There was a problem hiding this comment.
in future there are chances that people start ignoring tenant id header assuming tenant scope is false. This line might cause an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done for OMS. As of now, all orders have same tenant_id, so removing this to eliminate unnecessary conditions in sql queries.