Conversation
A comment in the custom Makefile says that we want fbcv.obo to be derived from fbcv-simple, but the actual rule immediately below that comment proceeds to derive fbcv.obo from fbcv.owl (which, as per the ODK rules, is the same thing as fbcv-full.owl). In all other FlyBase ontologies (FBdv, FBbt, and DPO), the main obo file X.obo is derived from X-simple.owl, so there's no reason for FBcv to do otherwise, especially since the comment explicitly states that this was the original intention.
Contributor
Author
|
⬆️ @Clare72 As discussed in today’s meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment in the custom Makefile says that we want fbcv.obo to be derived from fbcv-simple, but the actual rule immediately below that comment proceeds to derive fbcv.obo from fbcv.owl (which, as per the ODK rules, is the same thing as fbcv-full.owl).
In all other FlyBase ontologies (FBdv, FBbt, and DPO), the main obo file X.obo is derived from X-simple.owl, so there should be no reason for FBcv to do otherwise, especially since the comment explicitly states that this was the original intention.