Merged
Conversation
ROBOT 1.9.8 now automatically takes care of removing duplicate labels, definitions, and comments from OBO output files, we no longer need to do it in custom rules.
The 'prepare_release' rule was overriden to make sure the
'flybase_controlled_vocabulary.obo' custom product was included in the
release assets.
But this can be achieved more simply by
(1) adding the file to 'MAIN_FILES' (so that it is copied over to the
release directory when running 'prepare_release'), and
(2) adding it to the 'all_assets' target (so that is is generated along
with all the other assets).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the repository to the latest version of the ODK (1.6).
The custom Makefile is simplified to remove the custom rules that created “clean” OBO artefacts (now done by the ODK itself) and to use a simpler way to ensure that
flybase_controlled_vocabulary.obois treated as a release artefact (without having to override theprepare_releasetarget).