Hotfix/Code clean, .Net8 , Workflow, Advanced #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still to add output
queueSizeLogG is default on 0.
Issue on line 95 with duplication
Output does not.
Close to done just don't have time to finish
Aligned variable declarations for consistency in Arma3Profile and BasicCfg. Removed unused properties and redundant event handling from ServerCfg. Ensured AdvancedOptions and its content are properly initialized in ServerProfile constructors.
Corrected inconsistent indentation for assignment of AdvancedOptionsContent in the ServerProfile class constructor to improve code readability.
Corrected typos in comments and property change notifications.
Corrects the assignment to set AdvancedOptionsContent instead of overwriting ServerCfgContent with advanced options in ServerProfile.cs.
Reorganized the FASTER.csproj file for improved readability and maintainability by properly indenting and grouping properties. No functional changes were made. Minor whitespace adjustments were also made in the CodeQL workflow YAML.
Changed target framework from net9.0-windows to net8.0-windows in both FASTER and FASTERTests projects. Updated version to 1.9.7.2 in project and version files to reflect the framework change.
Added <EnableWindowsTargeting>true</EnableWindowsTargeting> to make Actions happy even though it isn't needed for net8 :shurg:
Added <EnableWindowsTargeting>true</EnableWindowsTargeting> to both FASTER - Backup.csproj and FASTERTests.csproj to explicitly enable Windows-specific APIs and features during build and development 🤷
Corrected the path to BytexDigital.Steam.csproj in FASTER.sln to remove a duplicate folder segment.
This reverts commit decc343.
Collaborator
Author
|
PLs mister nuget just work 😢 |
Changed the checkout step in the CodeQL workflow to use 'submodules: recursive' and added a token for authentication. This ensures all nested submodules are checked out and authenticated properly.
Introduced a debugging step to list all files before checking out the repository in the CodeQL analysis workflow. This helps diagnose issues related to file structure or missing files during CI runs. (unlikely to keep in)
Removed the debugging file listing step and added an explicit step to initialize and update submodules using git. This ensures submodules are properly set up before running CodeQL analysis.
Collaborator
Author
|
Only reason I'm not just pushing is is cause of what i added into the Workflow. everything else is basic cleanup. |
The SDK version specified in global.json has been changed from 9.0.0 to 8.0.0, likely to ensure compatibility with projects or tooling that require .NET 8.0.0.
Hotfix/AdvancedOptions
jupster
changed the title
Collaborator
Author
|
4 things to fix this week 🔢 |
Owner
|
That merge will have to be a squash to avoid too many commits. |
Collaborator
Author
|
ahh will prob just squish it to make it easy |
|
purge button? 😬 |
Collaborator
Author
Won't add it to this but I'll check it out once I've gotten this all added. It still needs some work iirc so would rather get it more completed before adding it |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: