Convert build system from CMake to Makefile #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the project's build system from CMake to Makefile: 1. Added a comprehensive Makefile with support for: - Building VM (Luau) source files - Compiling source/cpp files for the static library - Linking everything into the final dylib - iOS-specific settings and compiler flags 2. Updated the GitHub workflow to: - Use the Makefile directly instead of CMake - Set proper environment variables for iOS builds - Maintain compatibility with the existing build process This change simplifies the build process while maintaining all the same functionality and output structure as before.
Author
|
You are out of Mentat credits; I won't iterate on CI failure. You can view and refresh your credits here. |
Author
|
I've fixed the issue in the Makefile that was causing the GitHub workflow to fail. The problem was that the flags Changes in this update:
The build should now complete successfully with the fixed Makefile. |
Author
|
You are out of Mentat credits; I won't iterate on CI failure. You can view and refresh your credits here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the project's build system from CMake to Makefile:
Added a comprehensive Makefile with support for:
Updated the GitHub workflow to:
This change simplifies the build process while maintaining all the same
functionality and output structure as before.
🤖 See my steps and cost here ✨