Skip to content

Fix closure capturing memoryObserver before declaration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
backup-bdg merged 1 commit into from
Apr 28, 2025
Merged

Fix closure capturing memoryObserver before declaration #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions iOS/Operations/CoreML/CoreMLManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,9 @@ final class CoreMLManager {
}
}

// Store the observer in a local variable first
let memoryObserver = NotificationCenter.default.addObserver(
// Create the observer without capturing itself
var memoryObserver: NSObjectProtocol?
memoryObserver = NotificationCenter.default.addObserver(
forName: UIApplication.didReceiveMemoryWarningNotification,
object: nil,
queue: .main
Expand All @@ -438,14 +439,18 @@ final class CoreMLManager {
}

// Remove the observer itself
NotificationCenter.default.removeObserver(memoryObserver)
if let observer = memoryObserver {
NotificationCenter.default.removeObserver(observer)
}

self?.isModelLoading = false
completion?(false)
}

// Store the observer in the array for later cleanup
memoryObservers.append(memoryObserver)
if let observer = memoryObserver {
memoryObservers.append(observer)
}

// Perform actual loading in background
predictionQueue.async { [weak self] in
Expand Down