[CFM_214] feat: Create SearchInfo popup #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronaearle
requested changes
Mar 4, 2023
Collaborator
jaronaearle
left a comment
jaronaearle
left a comment
There was a problem hiding this comment.
Left a few comments.
| position: 'fixed', | ||
| top: 157, | ||
| right: 16, | ||
| zIndex: 999, |
Collaborator
There was a problem hiding this comment.
Is a z-index of 999 really necessary? It doesn't look like there are any other elements nearby competing for visibility so a lower number value should be fine here.
Collaborator
Author
There was a problem hiding this comment.
It looks like
.leaflet-pane {
z-index: 400;
}so it must be higher than that
Collaborator
There was a problem hiding this comment.
Gah, that is kind of annoying. Where what nearby element is using that class?
Collaborator
Author
There was a problem hiding this comment.
The map is using it.
seanred360
force-pushed
the
cfm_214_sr
branch
3 times, most recently
from
671317a to
1dc45ab
Compare
bernardm
force-pushed
the
dev
branch
2 times, most recently
from
a01694d to
9eec6ba
Compare
bernardm
force-pushed
the
dev
branch
2 times, most recently
from
4334d54 to
da21db6
Compare
bernardm
force-pushed
the
dev
branch
4 times, most recently
from
8dd6ad5 to
2859cbc
Compare
bernardm
force-pushed
the
dev
branch
3 times, most recently
from
3d7fb6c to
c49d3cc
Compare
bernardm
force-pushed
the
dev
branch
2 times, most recently
from
6af299f to
745ebee
Compare
bernardm
force-pushed
the
dev
branch
3 times, most recently
from
0fa9d66 to
7b8cc22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFM_214.feat_.Create.SearchInfo.popup.mp4