Skip to content

Conversation

@bernardm
Copy link
Collaborator

No description provided.

@bernardm bernardm changed the title chore: Update Fridge Finder REST API [CFM_190] chore: Update Fridge Finder REST API May 6, 2023
@bernardm
Copy link
Collaborator Author

bernardm commented May 6, 2023

Trello Card

description: Staging server (uses test data)

paths:
/v1/fridges:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the logic behind removing versioning?

Copy link
Collaborator Author

@bernardm bernardm May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not removed versioning. The version is in the url path of the server. It’s on line 23. I added a server field so both the dev and prod AWS lambdas can be queried directly from the Swagger Editor

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh perfect!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really cool :)

description: Unexpected error prevented server from fulfilling request.

/v1/fridges/{id}/reports:
/reports/last:
Copy link
Collaborator

@1jeanpaul1 1jeanpaul1 May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


foodPercentage:
description: The percentage of food in the fridge.
foodAmount:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foodAmount is more fitting, but this will require a data migration so I would keep it as foodPercentage for now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants