-
Notifications
You must be signed in to change notification settings - Fork 6
[CFM_190] chore: Update Fridge Finder REST API #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| description: Staging server (uses test data) | ||
|
|
||
| paths: | ||
| /v1/fridges: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the logic behind removing versioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not removed versioning. The version is in the url path of the server. It’s on line 23. I added a server field so both the dev and prod AWS lambdas can be queried directly from the Swagger Editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's really cool :)
| description: Unexpected error prevented server from fulfilling request. | ||
|
|
||
| /v1/fridges/{id}/reports: | ||
| /reports/last: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, made a ticket for it: https://trello.com/c/hdvp8cEX/248-cfm219-add-reports-last-api
|
|
||
| foodPercentage: | ||
| description: The percentage of food in the fridge. | ||
| foodAmount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foodAmount is more fitting, but this will require a data migration so I would keep it as foodPercentage for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But will create a ticket for it: https://trello.com/c/DIpAHBPK/249-cfm220-change-foodpercentage-to-foodamount
a01694d to
9eec6ba
Compare
4334d54 to
da21db6
Compare
2ae9302 to
c5b9efa
Compare
8dd6ad5 to
2859cbc
Compare
3d7fb6c to
c49d3cc
Compare
6af299f to
745ebee
Compare
0fa9d66 to
7b8cc22
Compare
No description provided.