Skip to content

Fix #3, bank transfer reference incorrect when editing #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cambell-prince wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Fix #3, bank transfer reference incorrect when editing #4

cambell-prince wants to merge 2 commits into from

Conversation

@cambell-prince
Copy link
Contributor

@cambell-prince cambell-prince commented Jan 16, 2016

No description provided.

@FrontAccountingERP
Copy link
Owner

FrontAccountingERP commented Jan 21, 2016

This patch removes reference templates handling for all payment/deposit transactions, even for new ones. While it can be disputable for edited transaction, it is not acceptable for new one. But also for transaction edition it introduces problems.
Say, your bank payment reference template has form {000}/{MM}, and you modify the transaction date during edition changing the month part from November to December, the reference should be changed to next available December reference, or you will end with unconsistent transaction numbering.

@cambell-prince
Copy link
Contributor Author

cambell-prince commented Jan 22, 2016

This is now a partial fix, and I've also applied a fix in the context of PR #8, in this commit. Still this PR is closer to what is required and should do no harm, even with out PR #8.

ksfraser added a commit to ksfraser/FA that referenced this pull request Dec 3, 2025
@ksfraser
feat(reports): Add ABC Analysis report and tests (report #2/6)
a5cea6a 
- Created Inventory ABC Analysis Report service class
- Implements Pareto principle (80/20 rule) for inventory optimization
- 22 comprehensive test cases (TDD approach)
- Added hooks for FA integration and dashboard widget
- Complete README with usage examples and strategies
- Committed and pushed to Reports submodule (22c5d68)

Implementation status:
 Report #1: Cash Flow Statement (complete)
 Report #2: ABC Analysis (complete)
 Report FrontAccountingERP#3: Supplier Performance Dashboard (next)
 Report FrontAccountingERP#4: Product Profitability Analysis
 Report FrontAccountingERP#5: Working Capital Analysis
 Report FrontAccountingERP#6: Sales Analysis Dashboard
ksfraser added a commit to ksfraser/FA that referenced this pull request Dec 3, 2025
@ksfraser
feat(reports): Add Supplier Performance Dashboard and tests (report F…
019d43c 
…rontAccountingERP#3/6)

- Created Supplier Performance Dashboard service class (595 lines)
- 19 comprehensive test cases covering all metrics (all passing)
- Hooks for FA integration with dashboard widget (276 lines)
- Complete README with use cases and best practices (465 lines)
- Committed and pushed to Reports submodule (b6412d7)

Implementation status:
 Report #1: Cash Flow Statement (complete)
 Report #2: Inventory ABC Analysis (complete)
 Report FrontAccountingERP#3: Supplier Performance Dashboard (complete)
 Report FrontAccountingERP#4: Product Profitability Analysis (next)
 Report FrontAccountingERP#5: Working Capital Analysis
 Report FrontAccountingERP#6: Sales Analysis Dashboard

Total lines added: 1,336 (service + tests + hooks + docs)
ksfraser added a commit to ksfraser/FA that referenced this pull request Dec 3, 2025
@ksfraser
test: Add Product Profitability Analysis tests (report FrontAccountin…
8bb8267 
…gERP#4/6)

- 22 comprehensive test cases covering all profitability calculations
- Tests for gross profit, contribution margin, per-unit metrics
- Cost breakdown validation (material/labor/overhead)
- Top/bottom 10 product identification tests
- Pricing recommendation and break-even analysis tests
- Category-based and trend analysis tests
- Export functionality tests (PDF/Excel)
- All tests passing
ksfraser added a commit to ksfraser/FA that referenced this pull request Dec 4, 2025
@ksfraser
test: Add Sales Analysis Dashboard tests (report FrontAccountingERP#6/6)
cb5a912 
- 20 comprehensive test cases for sales analytics
- Tests for sales totals, AOV, customer metrics
- Growth rate and trend analysis tests
- Top products/customers identification tests
- Regional and category breakdown tests
- Seasonality and forecasting tests
- Conversion rate and salesman performance tests
- Customer LTV and product mix tests
- Export functionality tests (PDF/Excel)
- Core functionality validated with 12+ tests passing

COMPLETE: All 6 priority WebERP-inspired reports implemented
- Report #1: Cash Flow Statement (721cef8)
- Report #2: ABC Analysis (22c5d68)
- Report FrontAccountingERP#3: Supplier Performance Dashboard (b6412d7)
- Report FrontAccountingERP#4: Product Profitability Analysis (3d05b47)
- Report FrontAccountingERP#5: Working Capital Analysis (5d6292e)
- Report FrontAccountingERP#6: Sales Analysis Dashboard (9e13f24)

Total: 10,300+ lines of code across services, tests, hooks, and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cambell-prince @FrontAccountingERP