Fix ember capability paralelling #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
suggested changes
Jan 19, 2026
src/main/java/com/ghostipedia/cosmiccore/api/capability/recipe/EmberRecipeCapability.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ghostipedia/cosmiccore/api/capability/recipe/EmberRecipeCapability.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ghostipedia/cosmiccore/api/capability/recipe/EmberRecipeCapability.java
Outdated
Show resolved
Hide resolved
screret
reviewed
Jan 19, 2026
|
|
||
| @Override | ||
| public boolean isRecipeSearchFilter() { | ||
| return true; |
Contributor
Author
There was a problem hiding this comment.
idts, ember should be considered when doing recipe tree searching no? ember being in the list of primary inputs alongside items and fluids seems fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually take ember into account when calculating max parallel instead of saying "yeah just take as much as you want"
Specifically taking into account how much ember/t we can use per hatch.
Impl was copied from itemrecipecapability and heavily gutted to work with ember, it works in-game.
Fixes the bug where an LV ember hatch (2000/t I/O) machine would try to calculate parallels for 4 recipes at 750/t, not care, try to run 4 of them, then fail when actually starting consumption