Solved: 300. Longest Increasing Subsequence #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuga-98
reviewed
Apr 14, 2025
| - numsをはじめから見ていって、各長さのLISにおける末尾の最小値を保持するやり方もあった | ||
| - 発想も素直な気がするのでこれは思いついても良さそうだった | ||
| - ついでに`bisect_left`の実装をみたが、変数名が雑すぎるなあ | ||
| - https://github.com/python/cpython/blob/3.13/Lib/bisect.py#L74 |
fuga-98
reviewed
Apr 14, 2025
| def lengthOfLIS(self, nums: List[int]) -> int: | ||
| length_lis = [1] * len(nums) | ||
| for index in range(len(nums)): | ||
| for former_index in range(index): |
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
見返してみると、
階層が深くなっているので関数化するのもありな気がしてきました。
oda
reviewed
Apr 14, 2025
Comment on lines
+67
to
+70
| if insertion_position == len(tails): | ||
| tails.append(num) | ||
| else: | ||
| tails[insertion_position] = num |
There was a problem hiding this comment.
私は、唐突にこれを逆にしたほうが素直かなと思いましたが
if insertion_position < len(tails):
tails[insertion_position] = num
else:
tails.append(num)趣味の範囲です。
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
確かに「収まっている場合->収まっていない場合」となっていた方が自然ですね。
olsen-blue
reviewed
Apr 17, 2025
| length_lis = [1] * len(nums) | ||
| for index in range(len(nums)): | ||
| for former_index in range(index): | ||
| if nums[index] > nums[former_index]: |
Owner
Author
There was a problem hiding this comment.
すみません。コメント見逃しておりました。
自分も、コード見返していたところ、同じ感想を持ちました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
300. Longest Increasing Subsequence