Solved: 121. Best Time to Buy and Sell Stock #37
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuminiton
commented
Apr 30, 2025
| if len(prices) < 2: | ||
| return 0 | ||
| max_profit = 0 | ||
| lowest_profit_so_far = prices[0] |
Owner
Author
There was a problem hiding this comment.
max_profitにつられて、lowest_price_so_farと間違えてますね。
fuga-98
reviewed
Apr 30, 2025
| return 0 | ||
| max_profit = 0 | ||
| min_price_so_far = prices[0] | ||
| for price in prices[1:]: |
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
これスライスしなくても動きそうですね。
おっしゃる通りですね。
番兵でも書けそうです。
max_profit = 0として、len(nums)==1の時はそのまま0で返すのが良さそうです。
oda
reviewed
May 1, 2025
Comment on lines
+67
to
+68
| if len(prices) < 2: | ||
| return 0 |
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
1の場合のみであるという意図は伝わりにくいですね。
おっしゃる通り、if len(prices) == 1: の方が素直ですね。
あと、なくても動きますね。
2日以上のデータが与えられたときのことを考えて67,68を書きましたが、
step2,3をやる中で、なくてもよいことに気付くべきでした。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
121. Best Time to Buy and Sell Stock