Solved: 122. Best Time to Buy and Sell Stock II #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuga-98
reviewed
Apr 30, 2025
| if len(prices) == 1: | ||
| return 0 | ||
| profit = 0 | ||
| yesterday_price = prices[0] |
nodchip
reviewed
May 1, 2025
| if len(prices) == 1: | ||
| return 0 | ||
| profit = 0 | ||
| prev_price = prices[0] |
There was a problem hiding this comment.
prev_price を定義せず
for day in range(len(prices) - 1):
profit += max(0, prices[day + 1] - prices[day])で回してもよいと思いました。
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
dayでループすると、前日と当日を比べていることが直感的に理解できてとても良いですね。
oda
reviewed
May 1, 2025
Comment on lines
+82
to
+83
| if len(prices) == 1: | ||
| return 0 |
| for i in range(1, len(prices)): | ||
| if prices[i] >= prices[i - 1]: | ||
| continue | ||
| profit += max(0, prices[i - 1] - buy_price) |
There was a problem hiding this comment.
このロジックだと、prices[i - 1] - buy_priceが負になることはなさそうなので、maxとの比較はいらないかもと思いました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
122. Best Time to Buy and Sell Stock II