Solved: 139. Word Break #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
May 2, 2025
|
|
||
| for i in range(1, len(s) + 1): | ||
| for word in wordDict: | ||
| if not 0 <= i - len(word) < len(s): |
There was a problem hiding this comment.
i - len(word) は一回変数に置き直したほうがいいでしょう。
s.endswith(word, 0, i) のほうが直感的ですかねー。
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
i - len(word) は一回変数に置き直したほうがいいでしょう。
word_start_indexと変数においてしまった方が分かりやすいですね。
Mike0121
reviewed
May 5, 2025
|
|
||
| while indices: | ||
| next_indices = [] | ||
| for index in indices: |
There was a problem hiding this comment.
自分だったらここ、start_index. start_indicesにすると思いました。
Owner
Author
There was a problem hiding this comment.
レビューありがとうございます。
start_indexとして方が、何を比較しているか見えるので良いですね。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
139. Word Break