Skip to content

Conversation

@anushreeag
Copy link
Contributor

when event is bookmarked/unbookmarked in detail Activity

…d/unbookmarked in detail Activity and we return to List of events
@anushreeag
Copy link
Contributor Author

@jaysondc @ganeshskudva : Do we need intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK); while starting DetailActivity ?

@jaysondc
Copy link
Contributor

jaysondc commented Nov 8, 2017

I don't think it needs to be to be a NEW_TASK. That flag causes the system to launch the activity in a whole separate task stack, with a different animation than when you normally launch an activity. This would probably break our shared element transition as well. We should be able to keep the launch mode as NORMAL which is described as the following:

Default. The system creates a new instance of the activity in the task from which it was started and routes the intent to it. The activity can be instantiated multiple times, each instance can belong to different tasks, and one task can have multiple instances.

This is correct because even if an instance of DetailActivity exists somewhere in the background, we want to launch a separate instance so it loads via a new intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants