Skip to content

Conversation

@Fx64b
Copy link
Owner

@Fx64b Fx64b commented Jan 18, 2025

No description provided.

Fx64b added 3 commits January 15, 2025 18:09
- improve room and corridor positions
- add corridors
- improve pathfinding throught corridors
- fix steps not being displayed properly
@vercel
Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fx64b-dev ✅ Ready (Inspect) Visit Preview May 12, 2025 4:50pm

Fix missing comma
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Marauders Map feature to the application by adding new modules for types, time handling, scheduling, character motion (including pathfinding), and a UI page to render the live map.

  • Added TypeScript type definitions for game entities and utility types.
  • Implemented scheduling, pathfinding, and character update logic for dynamic map behavior.
  • Developed a client-side React component to render and animate the Marauders Map using SVG.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/fun/marauders-map/types.ts New type definitions for time blocks, characters, rooms, and related data structures.
app/fun/marauders-map/time.ts Utility function to map game time to a time block, including a dual night block handling.
app/fun/marauders-map/schedule.ts Scheduling, character movement, and footstep creation logic for dynamic behavior.
app/fun/marauders-map/pathfinding.ts A* pathfinding implementation with grid creation and corridor integration.
app/fun/marauders-map/page.tsx A React component rendering the Marauders Map UI, character movements, and debug overlays.
app/fun/marauders-map/constants.ts Constants for layout, timing, paths, and room data used throughout the feature.
Comments suppressed due to low confidence (2)

app/fun/marauders-map/page.tsx:45

  • The 'updateCharacter' function is called using a 'gameTime' value from the closure, which may be stale after 'setGameTime' is updated. Consider computing the new 'gameTime' and passing that value to ensure the character updates are synchronized with the latest time.
prevCharacters.map(char => updateCharacter(char, currentTime, gameTime, gridRef.current))

app/fun/marauders-map/time.ts:5

  • The logic for night time blocks splits the night into two values ('NIGHT1' for hours >= 22 and 'NIGHT2' for hours < 6) even though both cover the same overall range. Verify whether this split is intentional or if adjustments to the conditions are needed.
if (hour >= 22 || hour < 6) {return hour >= 22 ? 'NIGHT1' : 'NIGHT2';}

@Fx64b
Copy link
Owner Author

Fx64b commented Sep 16, 2025

@copilot update this branch and resolve merge conflicts if they occure

@Fx64b Fx64b closed this Sep 21, 2025
@Fx64b Fx64b reopened this Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants