Skip to content

Conversation

@arng40
Copy link
Contributor

@arng40 arng40 commented Nov 18, 2025

This PR aim to create a new CI Target in order to ensure the use of the internal tool in geos and to promote the best coding practice.
First, this PR set up the CI check_code_rules and will ensure the use of : stdMap, stdUnorderedMap& stdVector
This PR will be merged after :

@arng40 arng40 self-assigned this Nov 18, 2025
@arng40 arng40 added type: CI Concerns github workflows or generic CI DO NOT MERGE ! flag: no rebaseline Does not require rebaseline labels Nov 18, 2025
@arng40 arng40 requested review from MelReyCG and jafranc December 8, 2025 13:09
Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the last two comments to be resolved.

@MelReyCG MelReyCG added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs and removed DO NOT MERGE ! labels Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 52.94118% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.97%. Comparing base (618c96f) to head (c7b0d76).

Files with missing lines Patch % Lines
src/coreComponents/mesh/graphs/GraphToolsMPI.cpp 0.00% 20 Missing ⚠️
...onents/linearAlgebra/multiscale/mesh/MeshLevel.cpp 0.00% 10 Missing ⚠️
...coreComponents/mesh/graphs/RLFGraphColoringMPI.cpp 0.00% 10 Missing ⚠️
...c/coreComponents/mesh/graphs/GraphColoringBase.cpp 18.18% 9 Missing ⚠️
...ents/linearAlgebra/multiscale/msrsb/MsrsbUtils.cpp 0.00% 4 Missing ⚠️
...oreComponents/mesh/generators/CellBlockManager.cpp 0.00% 3 Missing ⚠️
...rAlgebra/multiscale/mesh/coarsening/Coarsening.cpp 0.00% 2 Missing ⚠️
...ebra/multiscale/msrsb/MsrsbLevelBuilderCoupled.cpp 0.00% 2 Missing ⚠️
src/coreComponents/mesh/DomainPartition.hpp 0.00% 2 Missing ⚠️
...compositional/parameters/KValueFlashParameters.cpp 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3914      +/-   ##
===========================================
- Coverage    59.31%   57.97%   -1.34%     
===========================================
  Files         1341     1338       -3     
  Lines       111642   111262     -380     
===========================================
- Hits         66216    64506    -1710     
- Misses       45426    46756    +1330     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: CI Concerns github workflows or generic CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants