-
Notifications
You must be signed in to change notification settings - Fork 0
changes for integration into proxySEM #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1197 1192 -5
=========================================
- Hits 1197 1192 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/Shiva into feature/integrationIntoProxySEM
…having with relative paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements configuration changes to make the Shiva library compatible with integration into the proxySEM project. The changes focus on making CAMP dependency optional, improving build system configuration, and resolving some compilation issues.
- Makes CAMP dependency optional through configuration flags
- Updates build system paths to use Shiva-specific variables instead of generic CMake variables
- Fixes type consistency and compilation issues in geometry and quadrature code
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/geometry/mapping/LinearTransform.hpp | Fixes type consistency and enables constexpr template evaluation |
| src/functions/quadrature/Quadrature.hpp | Comments out runtime assertions and fixes fallback return value |
| src/common/types.hpp | Comments out CAMP dependency macro definition |
| src/common/pmpl.hpp | Adds missing memory copy and fixes comment formatting |
| src/common/CMakeLists.txt | Updates include paths to use Shiva-specific variables |
| src/ShivaConfig.hpp.in | Adds CAMP configuration option |
| src/CMakeLists.txt | Updates include path to use Shiva-specific variable |
| scripts/aggregateOrSplit.py | Improves path normalization and duplicate handling |
| docs/doxygen/ShivaConfig.hpp | Adds CAMP configuration option for documentation |
| cmake/Config.cmake | Adds CAMP to preprocessor defines list |
| cmake/CMakeBasics.cmake | Adds CAMP configuration option with default OFF |
| CMakeLists.txt | Makes CAMP dependency conditional and improves submodule handling |
| .gitmodules | Updates submodule URLs to use HTTPS instead of relative paths |
Comments suppressed due to low confidence (2)
src/common/pmpl.hpp:1
- The error check uses cudaSuccess but should use deviceSuccess for consistency with the abstraction layer defined above. This creates a dependency on CUDA-specific constants even when HIP might be used.
/*
src/common/pmpl.hpp:1
- Similar to the previous memory copy, this uses cudaMemcpyDeviceToHost directly instead of using the abstraction layer. This should use a generic deviceMemcpyDeviceToHost constant.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.