Skip to content

Conversation

@rrsettgast
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d9167ec) to head (63d667d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1197      1192    -5     
=========================================
- Hits          1197      1192    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rrsettgast rrsettgast requested a review from Copilot September 10, 2025 14:00
@rrsettgast rrsettgast self-assigned this Sep 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements configuration changes to make the Shiva library compatible with integration into the proxySEM project. The changes focus on making CAMP dependency optional, improving build system configuration, and resolving some compilation issues.

  • Makes CAMP dependency optional through configuration flags
  • Updates build system paths to use Shiva-specific variables instead of generic CMake variables
  • Fixes type consistency and compilation issues in geometry and quadrature code

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/geometry/mapping/LinearTransform.hpp Fixes type consistency and enables constexpr template evaluation
src/functions/quadrature/Quadrature.hpp Comments out runtime assertions and fixes fallback return value
src/common/types.hpp Comments out CAMP dependency macro definition
src/common/pmpl.hpp Adds missing memory copy and fixes comment formatting
src/common/CMakeLists.txt Updates include paths to use Shiva-specific variables
src/ShivaConfig.hpp.in Adds CAMP configuration option
src/CMakeLists.txt Updates include path to use Shiva-specific variable
scripts/aggregateOrSplit.py Improves path normalization and duplicate handling
docs/doxygen/ShivaConfig.hpp Adds CAMP configuration option for documentation
cmake/Config.cmake Adds CAMP to preprocessor defines list
cmake/CMakeBasics.cmake Adds CAMP configuration option with default OFF
CMakeLists.txt Makes CAMP dependency conditional and improves submodule handling
.gitmodules Updates submodule URLs to use HTTPS instead of relative paths
Comments suppressed due to low confidence (2)

src/common/pmpl.hpp:1

  • The error check uses cudaSuccess but should use deviceSuccess for consistency with the abstraction layer defined above. This creates a dependency on CUDA-specific constants even when HIP might be used.
/*

src/common/pmpl.hpp:1

  • Similar to the previous memory copy, this uses cudaMemcpyDeviceToHost directly instead of using the abstraction layer. This should use a generic deviceMemcpyDeviceToHost constant.
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rrsettgast rrsettgast merged commit 2db51da into main Sep 12, 2025
21 checks passed
@rrsettgast rrsettgast deleted the feature/integrationIntoProxySEM branch September 12, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants