add support for including Graphs as States of GFlowNet#183
Closed
add support for including Graphs as States of GFlowNet#183
Conversation
|
Hi, is there any further plan on implementing this feature? What's the bugs so far? Is there anything I could help out? And if I just want to hack it, can I simply copy the |
Collaborator
|
Hi @LicoriceLin yes there is a plan and it's now a top priority. A few of us will be looking at adding this feature starting next week and we would love your help and or feedback on the implementation to ensure we're able to support your needs. CC @younik |
Collaborator
|
@josephdviviano I believe there is no benefit in keeping this one open, given that we have #210. Right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Type: Feature
Add support for including Graphs as States of GFlowNet
The Graph structure is represented via the
Dataclass of Torch Geometric. The GraphStates object is represented via theBatchclass which encapsulates batching ofDataobjects and their efficient indexing. As opposed to the existing States object which requires appending dummy states for batching different length Trajectories together, we seek to support Trajectories by representing it as nestedBatchobject.The existing implementation of Trajectory supports the following indexing dimensions:
(Num time steps, Num trajectories, State Size). The nested Batch of Batch object representing state Trajectories would naturally indexing of the form (Num trajectories, Num timesteps, State size), and would need to implement logic for flipping the indexing dimensions internally in_getitem_()and_setitem_().Issue Number
#153
Testing