Skip to content

Uniformize logging#464

Merged
younik merged 4 commits intomasterfrom
uniformize-logging
Feb 5, 2026
Merged

Uniformize logging#464
younik merged 4 commits intomasterfrom
uniformize-logging

Conversation

@younik
Copy link
Collaborator

@younik younik commented Jan 29, 2026

Fixes #393

@younik younik requested a review from josephdviviano January 29, 2026 10:46
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.44%. Comparing base (2b03b38) to head (1d75862).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/gfn/utils/handlers.py 37.50% 5 Missing ⚠️
src/gfn/modules.py 0.00% 3 Missing ⚠️
src/gfn/utils/compile.py 0.00% 3 Missing ⚠️
src/gfn/gym/diffusion_sampling.py 80.00% 2 Missing ⚠️
src/gfn/utils/distributed.py 0.00% 2 Missing ⚠️
src/gfn/utils/common.py 66.66% 1 Missing ⚠️
src/gfn/utils/training.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   74.45%   74.44%   -0.02%     
==========================================
  Files          47       47              
  Lines        6890     6899       +9     
  Branches      820      820              
==========================================
+ Hits         5130     5136       +6     
- Misses       1449     1452       +3     
  Partials      311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@younik younik merged commit b498f32 into master Feb 5, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

library-wide logging standards

2 participants