Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
- Coverage 74.45% 74.32% -0.14%
==========================================
Files 47 47
Lines 6890 6951 +61
Branches 820 824 +4
==========================================
+ Hits 5130 5166 +36
- Misses 1449 1475 +26
+ Partials 311 310 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josephdviviano
approved these changes
Feb 5, 2026
Collaborator
josephdviviano
left a comment
josephdviviano
left a comment
There was a problem hiding this comment.
I'm approving because I dont have a better idea of what to do, but I worry about moving the logic into the states class making things more difficult.
| forward_masks[~is_done, -1] = False | ||
| return forward_masks | ||
|
|
||
| def _compute_backward_masks(self) -> torch.Tensor: |
Collaborator
There was a problem hiding this comment.
This is good work, but I'm worried that moving all of this logic into the States class makes the code more cumbersome and confusing to work with for other people. Is there another way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes point 2 of #377