feat: configure LMDB db sizes in config file#12
Draft
kentbull wants to merge 3 commits intoGLEIF-IT:v1.2.8from
Draft
feat: configure LMDB db sizes in config file#12kentbull wants to merge 3 commits intoGLEIF-IT:v1.2.8from
kentbull wants to merge 3 commits intoGLEIF-IT:v1.2.8from
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.2.8 #12 +/- ##
==========================================
- Coverage 92.25% 92.24% -0.02%
==========================================
Files 119 119
Lines 45774 45717 -57
==========================================
- Hits 42231 42171 -60
- Misses 3543 3546 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use of a proper key word arg is more Pythonic and easier to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to configure LMDB sizes using the bootstrap configuration file.
Also adds some INFO level logging on the config file location and database sizes set.
Adds the
.mapSizeproperty to LMDBer and theLMDBer.ConfigKeythat is overridden in each subclass. This config key is used to select a subset of the overall config file to use to configure each LMDBer subclass.For backwards compatibility the
KERI_BASER_MAP_SIZEenvironment variable still works, yet may be deprecated in the future. Moving forward using the configuration file as the single source of truth for configuration is the recommended path.The other GLEIF-IT/keripy specific environment variables have been removed in favor of the configuration file approach shown below.
There is both a global
lmdberconfig block and the subclass specific blocks shown below illustrate how to configure map sizes either globally or per class.