feat: controller mode with SallyAgent, add salt and logging args, health endpoint, curls config, better logging#33
Closed
kentbull wants to merge 5 commits intoGLEIF-IT:mainfrom
Closed
Conversation
a0897e6 to
6650300
Compare
3336cf3 to
b192dc7
Compare
b192dc7 to
a1fd19c
Compare
a1fd19c to
33b44da
Compare
Collaborator
Author
|
I force-pushed this today after updating it to the latest code since merging 0.10.0 to main. This will be v1.0.0. Once I test it again and verify both indirect and direct mode continue to produce the same results then I will take this from draft to ready to review. |
Collaborator
Author
|
closing in favor of the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
--saltarg tosally server startand passes it through to the Habery creation so that separate initialization and inception are no longer required.--loglevelcommand tosally server startso that the log level can be configured by command line argument./healththat shows a health message, the version of Sally, and some basic metrics.A sample healthcheck response looks like this:
{ "message": "Health is okay. Time is 2025-02-06T23:49:47.673704+00:00", "version": "0.9.4", "counts": { "senders": 0, "iss": 0, "rev": 0, "recv": 0, "revk": 0, "ack": 0 } }