feat: bundle inception and salt with sally server start#35
Merged
kentbull merged 4 commits intoGLEIF-IT:mainfrom Mar 25, 2025
Merged
feat: bundle inception and salt with sally server start#35kentbull merged 4 commits intoGLEIF-IT:mainfrom
kentbull merged 4 commits intoGLEIF-IT:mainfrom
Conversation
3d3b659 to
4d84371
Compare
c567b3b to
51e5303
Compare
51e5303 to
8982342
Compare
b3bff37 to
c106fc1
Compare
m00sey
approved these changes
Mar 25, 2025
and add healthcheck endpoint to hook demo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies Sally server management by allowing specification of inception configuration and Habery (keystore) configuration all in the
sally server startcommand. Any existingsallyHabery or AID are recognized and used though if they do not exist then a default one is created. Or, if the appropriate arguments are specified, a specific Sally AID is created.kli initwith--salt(--config-dirand--config-filealready existed) andkli inceptwith--incept-file--loglevel/-largument to specify loglevel. Defaults toINFOOther small refactorings:
/healththat also shows some basic presentation count metrics.PresentationProofHandlerfromrecurtoprocessNotesand callsprocessNotesfromrecur.httpingfor reusability.if listenargument inserving.pysince this indirect version of Sally will not need to use thelistenargument. The next version of Sally (see my draft PR) removes the indirect version of Sally and changes the setup function.