Skip to content

Comments

feat: bundle inception and salt with sally server start#35

Merged
kentbull merged 4 commits intoGLEIF-IT:mainfrom
kentbull:add-salt-and-bundled-inception
Mar 25, 2025
Merged

feat: bundle inception and salt with sally server start#35
kentbull merged 4 commits intoGLEIF-IT:mainfrom
kentbull:add-salt-and-bundled-inception

Conversation

@kentbull
Copy link
Collaborator

@kentbull kentbull commented Mar 21, 2025

This simplifies Sally server management by allowing specification of inception configuration and Habery (keystore) configuration all in the sally server start command. Any existing sally Habery or AID are recognized and used though if they do not exist then a default one is created. Or, if the appropriate arguments are specified, a specific Sally AID is created.

  • For setup replaces kli init with --salt (--config-dir and --config-file already existed) and kli incept with --incept-file
  • Adds --loglevel / -l argument to specify loglevel. Defaults to INFO

Other small refactorings:

  • Adds a healthcheck endpoint at /health that also shows some basic presentation count metrics.
  • Moves business logic in the PresentationProofHandler from recur to processNotes and calls processNotes from recur.
  • Improves logging findability by adding a human-readable type label to the dicts sent to the webhook.
  • moves the CORS middleware and CESR headers to functions in httping for reusability.
  • Removes the if listen argument in serving.py since this indirect version of Sally will not need to use the listen argument. The next version of Sally (see my draft PR) removes the indirect version of Sally and changes the setup function.
  • Adds a Python Pip cache to the pipeline and cleans up the Makefile.

@kentbull kentbull force-pushed the add-salt-and-bundled-inception branch 4 times, most recently from 3d3b659 to 4d84371 Compare March 22, 2025 19:11
@kentbull kentbull requested a review from m00sey March 24, 2025 19:01
@kentbull kentbull force-pushed the add-salt-and-bundled-inception branch 3 times, most recently from c567b3b to 51e5303 Compare March 24, 2025 19:30
@kentbull kentbull force-pushed the add-salt-and-bundled-inception branch from 51e5303 to 8982342 Compare March 24, 2025 19:44
@kentbull kentbull force-pushed the add-salt-and-bundled-inception branch from b3bff37 to c106fc1 Compare March 25, 2025 20:05
and add healthcheck endpoint to hook demo
@kentbull kentbull merged commit 8a45f52 into GLEIF-IT:main Mar 25, 2025
2 checks passed
@kentbull kentbull deleted the add-salt-and-bundled-inception branch March 25, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants