Fix first time grant failure bug#48
Merged
kentbull merged 4 commits intoGLEIF-IT:mainfrom Sep 8, 2025
Merged
Conversation
This was caused by an indentation bug written by me back in Q1 2025 and committed to WebOfTrust/keripy in March 2025.
This generally clarifies logger usage to use an explicit name to get a logger so that the default hio logger is not used and so that all logs explicitly go to the "sally" labeled logger for traceability and clarity.
Returning a list of Doers from serving.setup makes Sally usable from an end-to-end simulation test, specifically from SignifyPy. This is how I diagnosed the double present bug. And the config bootstrapper allows Sally to be started without a preexisting AID as the bootstrapper will OOBI with the configured witnesses prior to starting up. This does not matter as much any more now that direct mode is used since we tend to avoid using witnesses when we use direct mode. The config bootstrapper is useful only when the auto-incepted AID relies on a witness for inception on first startup.
f179f99 to
0143f13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a few things with the most important being upgrading to GLEIF-IT/keripy 1.2.8 including the exchange message processing fix
Other parts:
oglerusage and pulled in theTruncatedFormatterfrom vLEI-Server and KERIA.sally server start ...is all you have to do, like the following command: