Skip to content

GPII-2653: Initial onboarding of the PSP - starting with just the language setting #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amb26 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GPII-2653: Initial onboarding of the PSP - starting with just the language setting #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc6db40
GPII-2653: Initial onboarding of the PSP - starting with just the lan…
amb26 Apr 23, 2018
e17e0c4
Merge branch 'master' into GPII-2653
amb26 Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions testData/preferences/snapset_2a.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
"http://registry.gpii.net/common/highContrast/enabled": true,
"http://registry.gpii.net/common/highContrastTheme": "white-black",
"http://registry.gpii.net/common/supportTool": ["dictionary"]
},
"http://registry.gpii.net/applications/net.gpii.psp": {
"http://registry.gpii.net/common/language": "en"
Copy link
Member

@javihernandez javihernandez Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, according to #640, this should be "en-US", right @danailbd ?

Copy link
Contributor

@danailbd danailbd Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think it should

}
}
}
Expand Down
3 changes: 3 additions & 0 deletions testData/preferences/snapset_2b.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
"http://registry.gpii.net/common/highContrast/enabled": true,
"http://registry.gpii.net/common/highContrastTheme": "white-black",
"http://registry.gpii.net/common/supportTool": ["dictionary"]
},
"http://registry.gpii.net/applications/net.gpii.psp": {
"http://registry.gpii.net/common/language": "en"
}
}
}
Expand Down
27 changes: 27 additions & 0 deletions testData/solutions/win32.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3206,6 +3206,33 @@
}
},

"net.gpii.psp": {
"name": "Personal Settings Panel",
"contexts": {
"OS": [{
"id": "win32",
"version": ">=5.0"
}]
},
"settingsHandlers": {
"configuration": {
"type": "gpii.settingsHandlers.webSockets",
"liveness": "live",
"options": {
"path": "net.gpii.psp"
},
"supportedSettings": {
"language": {},
Copy link
Member

@javihernandez javihernandez Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to include the metadata for this settitng? I guess that we want it to be there if we want to get it rendered in the PSP.

Copy link
Member

@sgithens sgithens Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in order to support editing it in the PPT

}
}
},
"isInstalled": [
{
"type": "gpii.deviceReporter.alwaysInstalled"
}
]
},

"net.gpii.uioPlus": {
"name": "UIO+",
"contexts": {
Expand Down
3 changes: 3 additions & 0 deletions tests/data/preferences/snapset_2c.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
"http://registry.gpii.net/common/highContrast/enabled": true,
"http://registry.gpii.net/common/highContrastTheme": "white-black",
"http://registry.gpii.net/common/supportTool": ["dictionary"]
},
"http://registry.gpii.net/applications/net.gpii.psp": {
"http://registry.gpii.net/common/language": "en"
}
}
}
Expand Down