Fixed copy error and added sort to HTML output for form and report#3
Open
bsevere wants to merge 3 commits intoGSA:masterfrom
Open
Fixed copy error and added sort to HTML output for form and report#3bsevere wants to merge 3 commits intoGSA:masterfrom
bsevere wants to merge 3 commits intoGSA:masterfrom
Conversation
|
@gbinal Any change this will make it into the main repo? |
|
@benbalter do you know if Gray Brooks has anyone else working on this project? |
Contributor
|
Hey folks, Bill, sorry for letting this drop by. I'm game to accept the pull request but unfortunately don't understand php well enough to confirm the code changes. Right now, I'm just maintaining the schema for the project. Tim, are you able to speak to the code changes? Otherwise, yeah - hitting up @benbalter for thoughts on the edit would be the next more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for including my previous changes.
I have fetched your latest commits and we are preparing for deployment. Some final testing turned up an error on the file copy in generate.php. The function expects a file name for the source and destination parameters. I added a loop to fix it.
I also added sorting for the HTML output as the items were being displayed out of order. Please let me know if you have any questions.
Thanks again for this great tool.
Bill