Routed Settings on Main Page #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafuvadze
requested changes
Dec 24, 2019
Collaborator
mafuvadze
left a comment
mafuvadze
left a comment
There was a problem hiding this comment.
Just touch up a few syntax stuff and double check that all your imports are used. Great work!!
| import React, {Component} from 'react'; | ||
| import { | ||
| Modal, | ||
| DatePickerIOS, |
Collaborator
There was a problem hiding this comment.
Why do we have a date picker? isn't the modal just gonna have read only information about the shift?
Comment on lines
+34
to
+35
| StartDate: new Date(), | ||
| EndDate: new Date(), |
Collaborator
There was a problem hiding this comment.
Be consistent in your naming scheme. Always use camelCase
| import {CalendarModal} from './CalendarModal'; | ||
| import { WeatherWidget } from 'react-native-weather'; | ||
|
|
||
| export default class Dashboard extends Component { |
Collaborator
There was a problem hiding this comment.
According to Vinit, we won't have a Dashboard component, so remove for now :(
| name="ios-settings" | ||
| size={24} | ||
| color="white" | ||
| onPress={() => navigation.navigate('Settings')} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.