Merged
Conversation
UltraProdigy
requested changes
Jan 30, 2026
Member
There was a problem hiding this comment.
Okay. Holy grind. I cannot believe you had the patience to do this, this took me a few hours to read over during work. I likely missed a couple of things but either way this is MUCH better than what was in before so thank you for the great effort. I pointed out a couple of things that could use attention.
The one thing I didn't pick out was non-capitalized proper nouns of directly referenced items, which is a slight inconsistency (some are some aren't, they propbably should be, like with Magicales, etc etc) I think that would be much easier to correct with a script than have me point out in review.
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
Member
UltraProdigy
left a comment
UltraProdigy
left a comment
There was a problem hiding this comment.
One more tiny thing and this looks gtm 👍
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
Dream-Master
added
the
🚧 Testing on Zeta
UltraProdigy
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huge Grammar and typo check on the whole BM Book.
A lot to review, most likely still mistakes in this, but this should have catched many of them.