WIP: Add SCF Potential#751
Conversation
adivijaykumar
force-pushed
the
gegenbauer
branch
from
3c2ad34 to
f9dc960
Compare
|
Awesome! I am on the road ATM, but I can take a look at this soon. |
nstarman
left a comment
nstarman
left a comment
There was a problem hiding this comment.
It's looking good! LMK when you want a full review and tests.
| Parameters | ||
| ---------- | ||
| t : `~galax.typing.BBtQuSz0` | ||
| t : `~galax._custom_types.BBtQuSz0` |
There was a problem hiding this comment.
True. We should fix this. Probably my just not having the types in the docstring. The actual annotations are authoritative 🤷 .
There was a problem hiding this comment.
For static analyses' sake we prefer the long-form exports. Annoying, I know, but it makes mypy happier.
| "wadler_lindig>=0.1.6", | ||
| "xmmutablemap>=0.1", | ||
| "zeroth>=1.0", | ||
| "spexial @ git+https://github.com/JAXtronomy/spexial.git@main", |
There was a problem hiding this comment.
unfortunately, spexial is unlikely to be released. Can you move the function into potential/scf/?
| "xmmutablemap>=0.1", | ||
| "zeroth>=1.0", | ||
| "spexial @ git+https://github.com/JAXtronomy/spexial.git@main", | ||
| "hypothesis>=6.135.14", |
There was a problem hiding this comment.
This is a test-time dependency. It can be added by uv add --group test hypothesis.
| "zeroth>=1.0", | ||
| "spexial @ git+https://github.com/JAXtronomy/spexial.git@main", | ||
| "hypothesis>=6.135.14", | ||
| "gala>=1.9.1", |
There was a problem hiding this comment.
Gala is already a test-time dependency. :)
2 participants
NOTE: Still being tested