Skip to content

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 17, 2025

This is working towards a new queries-over-time component, by refactoring the mutations-over-time-grid into a reusable component.

Summary

Rename MutationsOverTimeGrid to FeaturesOverTimeGrid and make it generic. You now need to also supply a:

FeatureRenderer<D> {
    asString(value: D): string;
    renderRowLabel(value: D): JSX.Element;
    renderTooltip(value: D, temporal: Temporal, proportionValue: ProportionValue | undefined): JSX.Element;
}

Rename MutationOverTimeMutationValue to ProportionValue as it's not mutation specific.

Screenshot

n/a

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
dashboard-components Error Error Dec 18, 2025 10:26am

@github-actions
Copy link
Contributor

There is no change in the changelog. This PR will not produce a new releasable version.

@fhennig fhennig changed the title WIP refactor(components): refactor mutations-over-time-grid into generic features-over-time-grid Dec 18, 2025
@fhennig fhennig self-assigned this Dec 18, 2025
@fhennig fhennig marked this pull request as ready for review December 18, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants