feat!(components): remove legacy mutations-over-time fetching #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
There is no change in the changelog. This PR will not produce a new releasable version. |
fhennig
force-pushed
the
remove-legacy-mut-over-time-fetching
branch
from
5ff5131 to
0fbf3e3
Compare
fhennig
force-pushed
the
remove-legacy-mut-over-time-fetching
branch
from
4e2b378 to
eded246
Compare
| }; | ||
| }, [granularity, lapis, lapisDateField, lapisFilter, sequenceType, displayMutations, useNewEndpoint]); | ||
|
|
||
| const { data, error, isLoading } = useWebWorker<MutationOverTimeWorkerResponse>( |
Collaborator
There was a problem hiding this comment.
I think we can also get rid of useWebWorker now.
| return dataPromise; | ||
| } | ||
|
|
||
| export type MutationOverTimeQuery = { |
Collaborator
There was a problem hiding this comment.
This type is now unused - since queryMutationsOverTimeData has quite a lot of arguments, do we want to keep using it?
Collaborator
There was a problem hiding this comment.
groupByMutation is now also unused.
Collaborator
There was a problem hiding this comment.
Don't we have the cells with the grey color anymore? If they still exist, we should add a test that shows them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING Change: the
useNewEndpointflag on themutations-over-timecomponent has been removed. The new endpoint (which you got previously by setting the setting totrue) is now the default. The old way of computing the values is not available anymore.Summary
After we're now using the new endpoint everywhere (in all dashboards), we can proceed to make it the default, and remove all code related to the old way of computing the data. This includes removing the web worker, which simplifies the code, because it was an exception.
useNewEndpointflag. The new endpoint will now become the default.queryDatesInDatasetinto its own file.Testing
The special code for the web worker mocking has been removed. New mocks are now in place that work the same way as for other components (with fetch-mock; built-in in the Storybook). Screenshots have. been updated.
I tested this PR by using it locally in the dashboards; a quick check of the W-ASAP dashboard showed that things were still working as expected.
Screenshot
n/a
PR Checklist
All necessary documentation has been adapted.For reference: