Asymmetric line flow (Refined); READY FOR REVIEW !!! by sambuddhac · Pull Request #789 · GenXProject/GenX.jl

sambuddhac · 2024-11-13T17:20:34Z

Description

This PR attempts to introduce bidirectional asymmetric transmission lines into the system. Such lines have different values of MW flow limits, loss percentage, and capacity expansion limits along the two directions. While doing so, this PR also ensures that there are also symmetric lines present in the system along with the asymmetric lines and modifies the code in such a way that backwards compatibility is maintained with the existing cases.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
Code has been tested to ensure all functionality works as intended.
CHANGELOG.md has been updated (if this is a 'notable' change).
I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Post-approval checklist for GenX core developers

After the PR is approved

Check that the latest changes on the target branch are incorporated, either via merge or rebase
Remember to squash and merge if incorporating into develop

src/configure_settings/configure_settings.jl

src/load_inputs/load_network_data.jl

src/write_outputs/transmission/write_nw_expansion.jl

sambuddhac · 2024-12-17T04:03:26Z

Hi @JesseJenkins and @lbonaldo , I have pushed all the modifications to the code base for this PR. Few things to note: First of all, as you will see, it's way more lengthy and complicated than what Jesse suggested to me previously. I first tried with the simpler version. But, was getting bidirectional flows on the asymmetric lines with Qian's example case even when we restricted the flow limits to zero in one of the directions for the asymmetric lines.

With some pondering, I realized that I was doing wrong indexing on the constraints and decision variables. So, I had to do a bit more digging and refining the code. The fundamental reasons for which the code is so much lengthier are: 1) I have both symmetric as well as asymmetric lines in a system and 2) In order to maintain backward compatibility with the existing example cases (As you will observe, I had to go to lengths to split the data-frame into two parts and assign separate variables and constraint names so that things stay clean and correct. I could not find an easier way to do this. I'll highly appreciate any feedback on this).

We tested with @qluo0320github 's example cases and it seems the results are sensible (?) However, I still get discrepancies when I benchmark against an actually symmetric system versus a "simulated" symmetric system (in which the asymmetric lines have the same flow limits, loss percentages, and transmission buildout in both directions). I am attaching hereby all the relevant flow comparison
Flow_Comparisons.xlsx
result file (the names should be self-explanatory) here for you to take a look.

I scrutinized the code several times, but couldn't spot any flaw so far. I would appreciate if you could point some obvious bug (if at all) that I might have missed. Also, I would appreciate taking a look at the quadratic loss formulation. I believe I did it right, but am not totally certain. Thank you so much !!! I have also updated most of the doc pages; I will wrap up parts of the transmission.jl doc page and make another push to close this.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 280 to 282 in 7d90bd9



	if setup["asymmetrical_trans_flow_limit"] ==1

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 289 to 290 in 7d90bd9

    
           cMaxFlow_out_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] <= EP[:eAvail_Trans_Cap_Pos][l] #Change these with Auxiliary  
        
           cMaxFlow_in_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] >= -EP[:eAvail_Trans_Cap_Neg][l] #Change these with Auxiliary

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 294 to 297 in 7d90bd9

    
           begin 
        
               cMaxFlow_out[l = 1:L, t = 1:T], vFLOW[l, t] <= EP[:eAvail_Trans_Cap][l] 
        
               cMaxFlow_in[l = 1:L, t = 1:T], vFLOW[l, t] >= -EP[:eAvail_Trans_Cap][l] 
        
           end)

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 299 in 7d90bd9

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 302 in 7d90bd9

if setup["asymmetrical_trans_flow_limit"] ==1

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 323 in 7d90bd9

    
           inputs["pPercent_Loss_Pos"][l] * (vTAUX_POS_ASYM[l, t]) + inputs["pPercent_Loss_Neg"][l] * (vTAUX_NEG_ASYM[l, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 327 in 7d90bd9

vTAUX_POS_ASYM[l, t] - vTAUX_NEG_ASYM[l, t] == vFLOW[(l+L_sym), t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 331 in 7d90bd9

    
           vTAUX_POS_ASYM[l, t] + vTAUX_NEG_ASYM[l, t] <= min(EP[:eAvail_Trans_Cap_Pos][l], EP[:eAvail_Trans_Cap_Neg][l])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 343 in 7d90bd9

vTAUX_NEG[l, t] <= EP[:eAvail_Trans_Cap][l] - vPROD_TRANSCAP_ON[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 370 in 7d90bd9

    
           vTAUX_NEG_ASYM[l, t] <= EP[:eAvail_Trans_Cap_Neg][l] - vPROD_TRANSCAP_ON_NEG_ASYM[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 377 in 7d90bd9

    
           vTAUX_POS_ASYM[l, t] <= EP[:eAvail_Trans_Cap_Pos][l] - vPROD_TRANSCAP_ON_POS_ASYM[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 401 in 7d90bd9

(1 - vTAUX_POS_ON_POS_ASYM[l, t]) * inputs["pTrans_Max_Possible_Pos"][l]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 406 in 7d90bd9

(1 - vTAUX_POS_ON_NEG_ASYM[l, t]) * inputs["pTrans_Max_Possible_Neg"][l]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 435 in 7d90bd9

vTAUX_NEG[l, t] <= EP[:eAvail_Trans_Cap][l] - vPROD_TRANSCAP_ON[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 459 in 7d90bd9

if setup["asymmetrical_trans_flow_limit"] ==1

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 470 to 471 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 473 to 474 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 480 in 7d90bd9

sum(vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 483 in 7d90bd9

sum(vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 511 in 7d90bd9

cTAuxOrderPos2[l in LOSS_LINES_SYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 515 in 7d90bd9

cTAuxOrderNeg2[l in LOSS_LINES_SYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 548 to 549 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Pos"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 551 to 552 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Neg"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 558 to 559 in 7d90bd9

    
           sum(vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS_ASYM[l, 0, t] == 
        
           vFLOW[(l+L_sym), t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 561 to 562 in 7d90bd9

    
           sum(vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG_ASYM[l, 0, t] == 
        
           -vFLOW[(l+L_sym), t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 571 in 7d90bd9

cTAuxMaxNeg_asym[l in LOSS_LINES_ASYM, s = 1:TRANS_LOSS_SEGS, t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 581 in 7d90bd9

cTAuxOrderPos1_asym[l in LOSS_LINES_ASYM, s = 1:TRANS_LOSS_SEGS, t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 585 in 7d90bd9

cTAuxOrderNeg1_asym[l in LOSS_LINES_ASYM, s = 1:TRANS_LOSS_SEGS, t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 589 in 7d90bd9

    
           cTAuxOrderPos2_asym[l in LOSS_LINES_ASYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 593 in 7d90bd9

    
           cTAuxOrderNeg2_asym[l in LOSS_LINES_ASYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 606 in 7d90bd9

inputs["pTrans_Max_Possible_Pos"][l] * (1 - vTAUX_POS_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 612 in 7d90bd9

inputs["pTrans_Max_Possible_Neg"][l] * (1 - vTAUX_NEG_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 625 to 626 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 628 to 629 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 635 in 7d90bd9

sum(vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 638 in 7d90bd9

sum(vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 666 in 7d90bd9

cTAuxOrderPos2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 670 in 7d90bd9

cTAuxOrderNeg2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

src/load_inputs/load_network_data.jl

src/model/core/transmission/investment_transmission.jl

src/model/core/transmission/transmission.jl

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 596 in 146916a

    
           cTAuxOrderNeg2_asym[l in LOSS_LINES_ASYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 609 in 146916a

inputs["pTrans_Max_Possible_Pos"][l] * (1 - vTAUX_POS_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 615 in 146916a

inputs["pTrans_Max_Possible_Neg"][l] * (1 - vTAUX_NEG_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 628 to 629 in 146916a

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 631 to 632 in 146916a

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 638 in 146916a

sum(vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 641 in 146916a

sum(vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 669 in 146916a

cTAuxOrderPos2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 673 in 146916a

cTAuxOrderNeg2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

src/model/core/transmission/transmission.jl

CHANGELOG.md

example_systems/1_three_zones_asymmetric_bidirectional/README.md

example_systems/1_three_zones_asymmetric_bidirectional/settings/genx_settings.yml

example_systems/1_three_zones_asymmetric_bidirectional/system/Network.csv

...tems/6_three_zones_w_multistage_asymmetric_bidirectional/inputs/inputs_p3/system/Network.csv

src/configure_settings/configure_settings.jl

src/load_inputs/load_network_data.jl

src/write_outputs/transmission/write_nw_expansion.jl

src/write_outputs/write_outputs.jl

lbonaldo

First round of review. Thanks @sambuddhac for this PR. In your opinion, which example case should we keep? The branch is now rebased with the latest develop.

src/write_outputs/transmission/write_nw_expansion.jl

…ple case

…al flag is turned on but the corresponding columns are not provided in the Networks.csv

…xpansion lines in network load file to speed up computation

…onal flows and fixed the loss writing

…ample cases to test multistage asymmetric builds

…flow

Add warning for potential issues with asymmetric flow in multistage capacity expansion.

…rrected indexing

sambuddhac

Reviewed and approved !!!

sambuddhac · 2026-01-26T21:10:40Z

This now looks good. However, I cannot view the change requested @lbonaldo , as I mentioned earlier. Can you please let me know at your earliest convenience? Otherwise, now it looks all good. Can be merged. I also resolved one conflict on the CHANGELOG. Thanks !!!

lbonaldo · 2026-01-27T21:49:32Z

precompile/case/settings/genx_settings.yml

+OverwriteResults: 1
+AsymmetricalTransFlowLimit: 1


I probably wouldn't modify the precompile case. Do we have a specific reason for this change?

Thanks for the feedback, Luca. I think the reason I was doing it initially, is because I wasn't sure if the changes would impact the precompile. But, we can surely have the original precompile.

lbonaldo · 2026-01-27T21:52:14Z

src/write_outputs/transmission/write_nw_expansion.jl

+    L = inputs["L"]
+
+    NetworkExpansion = setup["NetworkExpansion"]
+    MultiStage = setup["MultiStage"]


Is this line being used?

lbonaldo · 2026-01-27T21:54:28Z

src/write_outputs/transmission/write_transmission_flows.jl

+    L_sym = inputs["L_sym"] # Number of transmission lines with symmetrical bidirectional flow
+    L_asym = inputs["L_asym"] #Default number of asymmetrical lines
+    # Number of lines in the network
+    L = L_sym + L_asym


Are L_sym and L_asym being used in other places other than at this line? If not, we could keep using L.

lbonaldo · 2026-01-27T21:55:51Z

src/configure_settings/configure_settings.jl

        "PoliciesFolder" => "policies",
-        "ObjScale" => 1)
+        "ObjScale" => 1,
+        "AsymmetricalTransFlowLimit" => 0


We need to update the documentation with this new settings key.

lbonaldo

Hi @sambuddhac, thank you for your recent changes to this PR. I’m doing a more comprehensive review, but in the meantime, I added a few more comments.
Do we want to keep all the new example cases? Right now we have 8 example cases for single stage, and 4 for multi-stage.

sambuddhac mentioned this pull request Nov 13, 2024

Update transmission.jl to account for asymmetrical directional flow l… #769

Closed

12 tasks

github-actions bot reviewed Nov 22, 2024

View reviewed changes

src/configure_settings/configure_settings.jl Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 3, 2024

View reviewed changes

src/load_inputs/load_network_data.jl Show resolved Hide resolved

lbonaldo added the enhancement New feature or request label Dec 3, 2024

lbonaldo force-pushed the asymmetric_line_flow branch from 0002caf to 0e224c5 Compare December 3, 2024 23:31

lbonaldo added this to the v0.4.2 milestone Dec 4, 2024

github-actions bot reviewed Dec 4, 2024

View reviewed changes

src/write_outputs/transmission/write_nw_expansion.jl Outdated Show resolved Hide resolved

sambuddhac changed the title ~~Asymmetric line flow (Refined) #Work in Progress; DO NOT MERGE YET !!!~~ Asymmetric line flow (Refined) #Work in Progress; READY FOR REVIEW !!! Dec 17, 2024

sambuddhac requested review from JesseJenkins and lbonaldo December 17, 2024 03:05

sambuddhac assigned JesseJenkins Dec 17, 2024

sambuddhac marked this pull request as ready for review December 17, 2024 15:02

sambuddhac changed the title ~~Asymmetric line flow (Refined) #Work in Progress; READY FOR REVIEW !!!~~ Asymmetric line flow (Refined); READY FOR REVIEW !!! Dec 18, 2024

github-actions bot reviewed Dec 18, 2024

View reviewed changes

GenXProject modified the milestones: v0.4.2, v0.4.3 Jan 16, 2025

lbonaldo force-pushed the asymmetric_line_flow branch from 1d3943a to 6fc5330 Compare January 17, 2025 15:11

lbonaldo reviewed Jan 17, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

example_systems/1_three_zones_asymmetric_bidirectional/README.md Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

example_systems/1_three_zones_asymmetric_bidirectional/settings/genx_settings.yml Outdated Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

example_systems/1_three_zones_asymmetric_bidirectional/system/Network.csv Outdated Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

...tems/6_three_zones_w_multistage_asymmetric_bidirectional/inputs/inputs_p3/system/Network.csv Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

src/configure_settings/configure_settings.jl Outdated Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

src/load_inputs/load_network_data.jl Outdated Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

src/write_outputs/transmission/write_nw_expansion.jl Outdated Show resolved Hide resolved

lbonaldo reviewed Jan 17, 2025

View reviewed changes

src/write_outputs/write_outputs.jl Outdated Show resolved Hide resolved

lbonaldo requested changes Jan 17, 2025

View reviewed changes

lbonaldo reviewed Jan 17, 2025

View reviewed changes

src/write_outputs/transmission/write_nw_expansion.jl Outdated Show resolved Hide resolved

sambuddhac and others added 17 commits January 6, 2026 12:41

Update transmission.jl

beb7124

Fixed the multistage asymmetric flow bug in file and added a new exam…

8e6c0d2

…ple case

Introduced try catch blocks to handle situations where the asymmetric…

4ffa87b

…al flag is turned on but the corresponding columns are not provided in the Networks.csv

Changed to uppercase for SYMMETRIC_LINE_INDEX and ASYMMETRIC_LINE_INDEX

cfaad01

Introduced the intersections for symmetric loss lines and symmetric e…

e1ad551

…xpansion lines in network load file to speed up computation

Included the transmission losses in the write outputs

e70c170

Modified the precompile case for incorporating asymmetrical bidirecti…

5547f88

…onal flows and fixed the loss writing

Update CHANGELOG.md

92b22db

placed the units at the end of the key with Neg and code cleanup

46354a6

Modified DDP file to have transmission builds across stages; Added ex…

2b619f4

…ample cases to test multistage asymmetric builds

Modifications to ddp.jl for incorporating multistage asymmetric line …

4c19468

…flow

Add warning for asymmetric flow issues

6592fa9

Add warning for potential issues with asymmetric flow in multistage capacity expansion.

Added try catch block for error handling for asymmetric multistage

fdccac2

Modified write_nw_expansion.jl to print Positive and Negative Transcap

1fc436d

Modified to used asymmetric expansion lines for correct indexing

86680d7

Made the columns of equal length in the output network writing and co…

431f7f3

…rrected indexing

Code clean up after rebase

5e7bdac

lbonaldo force-pushed the asymmetric_line_flow branch from 6e87ae1 to 5e7bdac Compare January 7, 2026 18:55

lbonaldo and others added 5 commits January 7, 2026 23:07

Fix latex symbols in docstrings

cf6295a

write new capacity for asym lines to output files

f469bea

Fix backward compatibility with symmetric lines and multistage

359fb69

Update tracking of tx capacity in multistage expansion

84b0716

Merge branch 'develop' into asymmetric_line_flow

d29e628

sambuddhac commented Jan 26, 2026

View reviewed changes

lbonaldo reviewed Jan 27, 2026

View reviewed changes

lbonaldo requested changes Jan 27, 2026

View reviewed changes

	cMaxFlow_out_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] <= EP[:eAvail_Trans_Cap_Pos][l] #Change these with Auxiliary
	cMaxFlow_in_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] >= -EP[:eAvail_Trans_Cap_Neg][l] #Change these with Auxiliary

	begin
	cMaxFlow_out[l = 1:L, t = 1:T], vFLOW[l, t] <= EP[:eAvail_Trans_Cap][l]
	cMaxFlow_in[l = 1:L, t = 1:T], vFLOW[l, t] >= -EP[:eAvail_Trans_Cap][l]
	end)

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) *
	vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) *
	vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Pos"][l] / TRANS_LOSS_SEGS) *
	vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Neg"][l] / TRANS_LOSS_SEGS) *
	vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

	sum(vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS_ASYM[l, 0, t] ==
	vFLOW[(l+L_sym), t]

	sum(vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG_ASYM[l, 0, t] ==
	-vFLOW[(l+L_sym), t]

		OverwriteResults: 1
		AsymmetricalTransFlowLimit: 1 No newline at end of file

Conversation

sambuddhac commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

How this can be tested

Post-approval checklist for GenX core developers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sambuddhac commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lbonaldo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sambuddhac left a comment

Choose a reason for hiding this comment

Uh oh!

sambuddhac commented Jan 26, 2026

Uh oh!

lbonaldo Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sambuddhac Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

lbonaldo Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

lbonaldo Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbonaldo Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

lbonaldo left a comment

Choose a reason for hiding this comment

sambuddhac commented Nov 13, 2024 •

edited

Loading

sambuddhac commented Dec 17, 2024 •

edited

Loading

lbonaldo left a comment •

edited

Loading

lbonaldo Jan 27, 2026 •

edited

Loading

lbonaldo Jan 27, 2026 •

edited

Loading