Deprecate HYDRO min_power in favour of min_flow#864
Open
lbonaldo wants to merge 7 commits intoGenXProject:developfrom
Open
Deprecate HYDRO min_power in favour of min_flow#864lbonaldo wants to merge 7 commits intoGenXProject:developfrom
min_power in favour of min_flow#864lbonaldo wants to merge 7 commits intoGenXProject:developfrom
Conversation
sambuddhac
approved these changes
Sep 18, 2025
Collaborator
sambuddhac
left a comment
There was a problem hiding this comment.
Looks good. Approved !!!
gschivley
reviewed
Sep 18, 2025
gschivley
reviewed
Sep 18, 2025
…w` for HYDRO resources
50e3079 to
f7aca4b
Compare
gschivley
reviewed
Jan 9, 2026
docs/src/User_Guide/model_input.md
Outdated
| | :------------ | :-----------| | ||
| |Min\_Flow |[0,1], The minimum generation level for a unit as a fraction of total capacity. This value cannot be higher than the smallest time-dependent CF value for a resource in `Generators_variability.csv`. **Recommended: Use this column for new inputs instead of `Min_Power`.**| | ||
| |Min\_Power |[0,1], **DEPRECATED**: Use `Min_Flow` instead. The minimum generation level for a unit as a fraction of total capacity. This value cannot be higher than the smallest time-dependent CF value for a resource in `Generators_variability.csv`.| | ||
| |Min\_Flow |[0,1], The minimum generation level for a unit as a fraction of total capacity. **Note**: setting a value greater than the time-dependent CF values for a resource in `Generators_variability.csv` can result in an infeasible model, because the model might not be able to generate enough power and/or discharge enough water to meet the minimum flow requirement. Always double check the variability data before running the model. |
Collaborator
There was a problem hiding this comment.
Very minor, but can you change because the model might not be able to generate to because the unit might not be able to generate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a deprecation path for the HYDRO
min_powercolumn and function, replacing them withmin_flow. This change improves code consistency, since the column is actually used to enforce a minimum outflow requirement (power generation + spillage).Changes Made
src/model/resources/resources.jl)Deprecated:
min_power(r::Hydro)function with deprecation warningsAdded: New
min_flow(r::Hydro)function that provides the same functionalityBackward Compatibility: Old function continues to work during transition period
Smart Fallback: Automatically detects and uses the appropriate column (
min_flowpreferred,min_poweras fallback)API Migration: Updated hydro constraints to use the new
min_flowAPIAPI Validation: Confirms new
min_flowfunction works with updated column namesdocs/src/User_Guide/model_input.md)Deprecated:
Min_Powercolumn is kept with deprecation noteAdded: New
Min_Flowcolumn is documentedMigration Guide
For Users:
Immediate: No action required - existing code continues to work
Recommended: Update input data to use
Min_Flowcolumn instead ofMin_PowerFuture:
min_powerfunction will be removed in a future breaking releaseFor Developers:
New Code: Use
min_flow(r::Hydro)instead ofmin_power(r::Hydro)Data Files: Rename
Min_Powercolumns toMin_Flowfor clarityBreaking Changes
None: This is a non-breaking change with full backward compatibility
Future:
min_powerfunction will be removed in a future breaking releaseWhat type of PR is this? (check all applicable)
Checklist
How this can be tested
By running the test suite.
Post-approval checklist for GenX core developers
After the PR is approved