Skip to content

Update HM contribution from allam cycle resources#896

Merged
lbonaldo merged 1 commit intoGenXProject:developfrom
lbonaldo:lb/fix-hm
Jan 27, 2026
Merged

Update HM contribution from allam cycle resources#896
lbonaldo merged 1 commit intoGenXProject:developfrom
lbonaldo:lb/fix-hm

Conversation

@lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Jan 9, 2026

Description

This PR updates the allam cycle module by fixing its contributrion to the hourly matching policy constraint.

What type of PR is this? (check all applicable)

  • Bug Fix
  • Documentation Update

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

By running the example 2_three_zones_w_electrolyzer_and_hourly_matching with allam cycle resources

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@sambuddhac
Copy link
Collaborator

Thanks @lbonaldo , I have reviewed, and asked two clarifying questions. Could you please confirm (or further qualify) if I understood right? If my suspicion is correct, seems the code looks right. Once I hear back from you, I will approve. Thanks !!!

@lbonaldo
Copy link
Collaborator Author

Hi @sambuddhac, thank you for reviewing this PR. I hope I’ve addressed your comments, but please let me know if I haven’t.

@sambuddhac
Copy link
Collaborator

Yes !!! It's now all good> Hi @sambuddhac, thank you for reviewing this PR. I hope I’ve addressed your comments, but please let me know if I haven’t.

@lbonaldo lbonaldo merged commit e00de3d into GenXProject:develop Jan 27, 2026
8 checks passed
@lbonaldo lbonaldo deleted the lb/fix-hm branch January 27, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants