Update HM contribution from allam cycle resources#896
Merged
lbonaldo merged 1 commit intoGenXProject:developfrom Jan 27, 2026
Merged
Update HM contribution from allam cycle resources#896lbonaldo merged 1 commit intoGenXProject:developfrom
lbonaldo merged 1 commit intoGenXProject:developfrom
Conversation
sambuddhac
reviewed
Jan 26, 2026
sambuddhac
reviewed
Jan 26, 2026
Collaborator
|
Thanks @lbonaldo , I have reviewed, and asked two clarifying questions. Could you please confirm (or further qualify) if I understood right? If my suspicion is correct, seems the code looks right. Once I hear back from you, I will approve. Thanks !!! |
Collaborator
Author
|
Hi @sambuddhac, thank you for reviewing this PR. I hope I’ve addressed your comments, but please let me know if I haven’t. |
Collaborator
|
Yes !!! It's now all good> Hi @sambuddhac, thank you for reviewing this PR. I hope I’ve addressed your comments, but please let me know if I haven’t. |
sambuddhac
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the allam cycle module by fixing its contributrion to the hourly matching policy constraint.
What type of PR is this? (check all applicable)
Checklist
How this can be tested
By running the example
2_three_zones_w_electrolyzer_and_hourly_matchingwith allam cycle resourcesPost-approval checklist for GenX core developers
After the PR is approved